Re: [PATCH v8] cfg80211: P2P find phase offload

[Johannes Berg <johannes@sipsolutions.net>]

> > > +struct cfg80211_p2p_find_params {
> > 
> > The parameters are missing the listen channel (which is needed to the listen phase).
> 
> There are n_channels and channels that define set of social channels
> to operate on. It applies to both listen and search.

I don't think that's true -- you only respond on the listen channel but
send probe requests on all the channels?

> > > +	attr = info->attrs[NL80211_ATTR_IE_PROBE_RESP];
> > > +	if (attr) {
> > > +		params.probe_resp_ie_len = nla_len(attr);
> > > +		params.probe_resp_ie = nla_data(attr);
> > > +	}
> > 
> > Is it valid to get Probe response IEs even if the driver did not report support for it?
> 
> One can't do p2p_find if it does not reply to P2P discovery probes.
> It is unrelated to answering probes in AP mode - driver may leave this
> to supplicant.

I think what Ilan is asking is whether you should reject the probe_resp
attribute if NL80211_FEATURE_P2P_PROBE_RESP_OFFLOAD isn't set. I'm fine
with just ignoring it (as is done now) though, might make wpa-s easier.

johannes