From: Johannes Berg <johannes@sipsolutions.net>
To: Thomas Pedersen <thomas@cozybit.com>
Cc: linux-wireless <linux-wireless@vger.kernel.org>,
open80211s <devel@lists.open80211s.org>
Subject: Re: [PATCH 2/2] mac80211: update mesh beacon on workqueue
Date: Mon, 10 Jun 2013 08:56:26 +0200 [thread overview]
Message-ID: <1370847386.8535.0.camel@jlt4.sipsolutions.net> (raw)
In-Reply-To: <CAG6hwVPbc=-airtoDSMmhzYQ+X64Qv42F+mnEQ5vbHjxC5wCew@mail.gmail.com> (sfid-20130610_044207_513100_0453AE65)
On Sun, 2013-06-09 at 19:41 -0700, Thomas Pedersen wrote:
> > +static void mesh_bss_info_changed(struct ieee80211_sub_if_data *sdata)
> > +{
> > + struct ieee80211_if_mesh *ifmsh = &sdata->u.mesh;
> > +#define TEST_CHANGED_BIT(bit) \
> > + test_and_clear_bit(bit, &ifmsh->mbss_changed)
> > +
> > + u32 changed = TEST_CHANGED_BIT(BSS_CHANGED_BEACON) |
> > + TEST_CHANGED_BIT(BSS_CHANGED_HT) |
> > + TEST_CHANGED_BIT(BSS_CHANGED_BASIC_RATES) |
> > + TEST_CHANGED_BIT(BSS_CHANGED_BEACON_INT);
> > +#undef TEST_CHANGED_BIT
>
> Uhhh we should read all the bits here. Will fix and resubmit as v2.
Now that you're quoting it I'd also say that the macro isn't really
best, does removing it really make the code so much worse?
johannes
next prev parent reply other threads:[~2013-06-10 6:56 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-03 23:25 [PATCH 1/2] mac80211: fix mesh deadlock Thomas Pedersen
2013-06-03 23:25 ` [PATCH 2/2] mac80211: update mesh beacon on workqueue Thomas Pedersen
2013-06-10 2:41 ` Thomas Pedersen
2013-06-10 6:56 ` Johannes Berg [this message]
2013-06-10 18:12 ` Thomas Pedersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1370847386.8535.0.camel@jlt4.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=devel@lists.open80211s.org \
--cc=linux-wireless@vger.kernel.org \
--cc=thomas@cozybit.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox