Linux wireless drivers development
 help / color / mirror / Atom feed
From: Johannes Berg <johannes@sipsolutions.net>
To: Ashok Nagarajan <ashok@cozybit.com>
Cc: linux-wireless@vger.kernel.org, linville@tuxdriver.com,
	devel@lists.open80211s.org, javier@cozybit.com
Subject: Re: [PATCH 1/2] iw: Allow user to provide freq during mesh join
Date: Tue, 11 Jun 2013 14:26:55 +0200	[thread overview]
Message-ID: <1370953615.8356.34.camel@jlt4.sipsolutions.net> (raw)
In-Reply-To: <1370280859-9860-1-git-send-email-ashok@cozybit.com> (sfid-20130603_193427_844091_21123EA3)

On Mon, 2013-06-03 at 10:34 -0700, Ashok Nagarajan wrote:
> Allow user to configure frequency and channel type during mesh join command.
> 
> Signed-off-by: Ashok Nagarajan <ashok@cozybit.com>
> ---
>  mesh.c |   49 ++++++++++++++++++++++++++++++++++++++++++++++---
>  1 files changed, 46 insertions(+), 3 deletions(-)
> 
> diff --git a/mesh.c b/mesh.c
> index 5a09b62..ec202c9 100644
> --- a/mesh.c
> +++ b/mesh.c
> @@ -431,8 +431,18 @@ static int join_mesh(struct nl80211_state *state, struct nl_cb *cb,
>  {
>  	struct nlattr *container;
>  	float rate;
> -	int bintval, dtim_period;
> +	int bintval, dtim_period, i;
>  	char *end;
> +	static const struct {
> +		const char *name;
> +		unsigned int val;
> +	} htmap[] = {
> +		{ .name = "HT20", .val = NL80211_CHAN_HT20, },
> +		{ .name = "HT40+", .val = NL80211_CHAN_HT40PLUS, },
> +		{ .name = "HT40-", .val = NL80211_CHAN_HT40MINUS, },
> +		{ .name = "NOHT", .val = NL80211_CHAN_NO_HT, },
> +	};

I think you should use chandefs already, to allow for VHT. Also, it'd be
good to refactor the channel parsing for this, monitor and IBSS (though
I wonder why I haven't done that already?)

johannes


  parent reply	other threads:[~2013-06-11 12:26 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-03 17:34 [PATCH 1/2] iw: Allow user to provide freq during mesh join Ashok Nagarajan
2013-06-03 17:34 ` [PATCH 2/2] iw: Allow basic rates to be configured when joining mesh Ashok Nagarajan
2013-06-11 12:26 ` Johannes Berg [this message]
2013-06-14 21:39   ` [PATCH 1/2] iw: Allow user to provide freq during mesh join Ashok Nagarajan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1370953615.8356.34.camel@jlt4.sipsolutions.net \
    --to=johannes@sipsolutions.net \
    --cc=ashok@cozybit.com \
    --cc=devel@lists.open80211s.org \
    --cc=javier@cozybit.com \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox