From: Johannes Berg <johannes@sipsolutions.net>
To: Yeoh Chun-Yeow <yeohchunyeow@gmail.com>
Cc: "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
John Linville <linville@tuxdriver.com>,
"devel@lists.open80211s.org" <devel@lists.open80211s.org>
Subject: Re: [PATCH] mac80211: allow key deletion for mesh interface
Date: Tue, 18 Jun 2013 11:36:03 +0200 [thread overview]
Message-ID: <1371548163.8318.2.camel@jlt4.sipsolutions.net> (raw)
In-Reply-To: <CAEFj987DCjNuv+W3oSq6ubHwjnkmKgKvcDThhP8s9ZXBsKmcjg@mail.gmail.com> (sfid-20130618_110728_700495_DC4DE8F2)
On Tue, 2013-06-18 at 17:07 +0800, Yeoh Chun-Yeow wrote:
> In sta_info_get_bss, should it be:
>
> if ((sta->sdata == sdata &&
> (sta->sdata->bss && sta->sdata->bss == sdata->bss))
>
> in stead of
>
> if ((sta->sdata == sdata ||
> (sta->sdata->bss && sta->sdata->bss == sdata->bss))
What would the point be? Then we could just as well make it *only*
sta->sdata == sdata
and it'd be the same as sta_info_get(). This is intentional for VLAN
handling.
> Otherwise, it seems that we still manage to get sta pointer even the
> bss is NULL.
What's the problem with that? But if this is a problem maybe we need to
explicitly check for non-NULL?
johannes
next prev parent reply other threads:[~2013-06-18 9:36 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-18 8:14 [PATCH] mac80211: allow key deletion for mesh interface Yeoh Chun-Yeow
2013-06-18 9:07 ` Yeoh Chun-Yeow
2013-06-18 9:36 ` Johannes Berg [this message]
2013-06-18 9:37 ` Johannes Berg
-- strict thread matches above, loose matches on Subject: below --
2013-06-18 4:07 Chun-Yeow Yeoh
2013-06-18 7:31 ` Johannes Berg
2013-06-18 9:39 ` Johannes Berg
2013-06-18 12:05 ` Yeoh Chun-Yeow
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1371548163.8318.2.camel@jlt4.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=devel@lists.open80211s.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=yeohchunyeow@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox