From: "Arend van Spriel" <arend@broadcom.com>
To: "John W. Linville" <linville@tuxdriver.com>
Cc: linux-wireless <linux-wireless@vger.kernel.org>,
"Arend van Spriel" <arend@broadcom.com>
Subject: [PATCH 2/8] brcmfmac: rename variable prec to more appropriate name, ie. fifo
Date: Tue, 18 Jun 2013 13:29:23 +0200 [thread overview]
Message-ID: <1371554970-23495-3-git-send-email-arend@broadcom.com> (raw)
In-Reply-To: <1371554970-23495-1-git-send-email-arend@broadcom.com>
The term prec (precedence) is different from the fifo number. Rename
use of prec with fifo to be consistent and clear.
Reviewed-by: Hante Meuleman <meuleman@broadcom.com>
Signed-off-by: Arend van Spriel <arend@broadcom.com>
---
drivers/net/wireless/brcm80211/brcmfmac/fwsignal.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/net/wireless/brcm80211/brcmfmac/fwsignal.c b/drivers/net/wireless/brcm80211/brcmfmac/fwsignal.c
index 1d8fa7d..e66b723 100644
--- a/drivers/net/wireless/brcm80211/brcmfmac/fwsignal.c
+++ b/drivers/net/wireless/brcm80211/brcmfmac/fwsignal.c
@@ -839,7 +839,7 @@ static int brcmf_fws_hdrpush(struct brcmf_fws_info *fws, struct sk_buff *skb)
static bool brcmf_fws_tim_update(struct brcmf_fws_info *fws,
struct brcmf_fws_mac_descriptor *entry,
- int prec, bool send_immediately)
+ int fifo, bool send_immediately)
{
struct sk_buff *skb;
struct brcmf_bus *bus;
@@ -848,10 +848,10 @@ static bool brcmf_fws_tim_update(struct brcmf_fws_info *fws,
u32 len;
/* check delayedQ and suppressQ in one call using bitmap */
- if (brcmu_pktq_mlen(&entry->psq, 3 << (prec * 2)) == 0)
- entry->traffic_pending_bmp &= ~NBITVAL(prec);
+ if (brcmu_pktq_mlen(&entry->psq, 3 << (fifo * 2)) == 0)
+ entry->traffic_pending_bmp &= ~NBITVAL(fifo);
else
- entry->traffic_pending_bmp |= NBITVAL(prec);
+ entry->traffic_pending_bmp |= NBITVAL(fifo);
entry->send_tim_signal = false;
if (entry->traffic_lastreported_bmp != entry->traffic_pending_bmp)
--
1.7.10.4
next prev parent reply other threads:[~2013-06-18 11:29 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-18 11:29 [PATCH 0/8] brcmfmac: scatterlist support in sdio and cleanup Arend van Spriel
2013-06-18 11:29 ` [PATCH 1/8] brcmfmac: Only use credits for bcmc when firmware indicates it Arend van Spriel
2013-06-18 11:29 ` Arend van Spriel [this message]
2013-06-18 11:29 ` [PATCH 3/8] brcmfmac: remove dependency with nl80211.h Arend van Spriel
2013-06-18 11:29 ` [PATCH 4/8] brcmfmac: consolidate mac_descriptor related function names Arend van Spriel
2013-06-18 11:29 ` [PATCH 5/8] brcmfmac: simplify dpc handling using atomic operations Arend van Spriel
2013-06-18 11:29 ` [PATCH 6/8] brcmfmac: remove redundant chip ID check in dhd_sdio Arend van Spriel
2013-06-18 11:29 ` [PATCH 7/8] brcmfmac: replace brcmf_sdioh_request_buffer with brcmf_sdio_buffrw Arend van Spriel
2013-06-18 11:29 ` [PATCH 8/8] brcmfmac: add sdio sg list support Arend van Spriel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1371554970-23495-3-git-send-email-arend@broadcom.com \
--to=arend@broadcom.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox