From: Chun-Yeow Yeoh <yeohchunyeow@gmail.com>
To: linux-wireless@vger.kernel.org
Cc: johannes@sipsolutions.net, linville@tuxdriver.com,
devel@lists.open80211s.org,
Chun-Yeow Yeoh <yeohchunyeow@gmail.com>
Subject: [PATCH] mac80211: fix the kernel panic on ath_tx_aggr_wakeup on mesh
Date: Fri, 21 Jun 2013 16:26:55 +0800 [thread overview]
Message-ID: <1371803215-2685-1-git-send-email-yeohchunyeow@gmail.com> (raw)
The is to fix the kernel panic happens if user space inserts the mesh
STA and not proceed with the SAE and AMPE, and later the same mesh STA
is detected again. The sta_state of the mesh STA remains at
IEEE80211_STA_NONE and if the ieee80211_sta_ps_deliver_wakeup
is called and subsequently the ath_tx_aggr_wakeup, the kernel panic due
to ath_tx_node_init is not called before to initialize the require data
structures.
This issue is reported by Cedric Voncken before.
http://www.spinics.net/lists/linux-wireless/msg106342.html
[<831ea6b4>] ath_tx_aggr_wakeup+0x44/0xcc [ath9k]
[<83084214>] ieee80211_sta_ps_deliver_wakeup+0xb8/0x208 [mac80211]
[<830b9824>] ieee80211_mps_sta_status_update+0x94/0x108 [mac80211]
[<83099398>] ieee80211_sta_ps_transition+0xc94/0x34d8 [mac80211]
[<8022399c>] nf_iterate+0x98/0x104
[<8309bb60>] ieee80211_sta_ps_transition+0x345c/0x34d8 [mac80211]
Thomas Perdersen also mentioned that this patch has fixed the
bad sta magic warning in mac80211_hwsim_set_tim() when applied to
mac80211-next/master
Signed-off-by: Chun-Yeow Yeoh <yeohchunyeow@gmail.com>
---
net/mac80211/mesh_ps.c | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/net/mac80211/mesh_ps.c b/net/mac80211/mesh_ps.c
index 3b7bfc0..0e42758 100644
--- a/net/mac80211/mesh_ps.c
+++ b/net/mac80211/mesh_ps.c
@@ -251,7 +251,8 @@ void ieee80211_mps_sta_status_update(struct sta_info *sta)
mps_dbg(sta->sdata, "start PS buffering frames towards %pM\n",
sta->sta.addr);
} else {
- ieee80211_sta_ps_deliver_wakeup(sta);
+ if (sta->sta_state >= IEEE80211_STA_ASSOC)
+ ieee80211_sta_ps_deliver_wakeup(sta);
}
/* clear the MPSP flags for non-peers or active STA */
--
1.7.0.4
next reply other threads:[~2013-06-21 8:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-21 8:26 Chun-Yeow Yeoh [this message]
2013-06-21 20:48 ` [PATCH] mac80211: fix the kernel panic on ath_tx_aggr_wakeup on mesh Johannes Berg
2013-06-24 0:44 ` Yeoh Chun-Yeow
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1371803215-2685-1-git-send-email-yeohchunyeow@gmail.com \
--to=yeohchunyeow@gmail.com \
--cc=devel@lists.open80211s.org \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox