Re: [PATCH] nl80211: fix mgmt tx status and testmode reporting for netns

[Johannes Berg <johannes@sipsolutions.net>]

On Mon, 2013-06-24 at 13:50 +0200, Michal Kazior wrote:
> These two events were sent to the default network
> namespace.
> 
> This caused AP mode in a non-default netns to not
> work correctly. Mgmt tx status was multicasted to
> a different (default) netns instead of the one the
> AP was in.

Good catch.

> @@ -6593,7 +6593,10 @@ void cfg80211_testmode_event(struct sk_buff *skb, gfp_t gfp)
>  
>  	nla_nest_end(skb, data);
>  	genlmsg_end(skb, hdr);
> -	genlmsg_multicast(skb, 0, nl80211_testmode_mcgrp.id, gfp);
> +
> +	rcu_read_lock();
> +	genlmsg_multicast_allns(skb, 0, nl80211_testmode_mcgrp.id, GFP_ATOMIC);
> +	rcu_read_unlock();
>  }
>  EXPORT_SYMBOL(cfg80211_testmode_event);

I think this one should get a wiphy parameter though, to put it into the
right netns.

johannes