From: "Arend van Spriel" <arend@broadcom.com>
To: "John W. Linville" <linville@tuxdriver.com>
Cc: linux-wireless <linux-wireless@vger.kernel.org>,
"Arend van Spriel" <arend@broadcom.com>
Subject: [PATCH 2/9] brcmfmac: remove (ab)use of NL80211_NUM_ACS
Date: Wed, 26 Jun 2013 14:20:15 +0200 [thread overview]
Message-ID: <1372249222-4858-3-git-send-email-arend@broadcom.com> (raw)
In-Reply-To: <1372249222-4858-1-git-send-email-arend@broadcom.com>
Used NL80211_NUM_ACS to indicate the BCMC fifo used in the driver
which has the same value now, but it is a bad idea relying on that.
Signed-off-by: Arend van Spriel <arend@broadcom.com>
---
drivers/net/wireless/brcm80211/brcmfmac/fwsignal.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/brcm80211/brcmfmac/fwsignal.c b/drivers/net/wireless/brcm80211/brcmfmac/fwsignal.c
index 41f902d..e4fd13a 100644
--- a/drivers/net/wireless/brcm80211/brcmfmac/fwsignal.c
+++ b/drivers/net/wireless/brcm80211/brcmfmac/fwsignal.c
@@ -1851,7 +1851,7 @@ static void brcmf_fws_dequeue_worker(struct work_struct *worker)
fws = container_of(worker, struct brcmf_fws_info, fws_dequeue_work);
brcmf_fws_lock(fws->drvr, flags);
- for (fifo = NL80211_NUM_ACS; fifo >= 0 && !fws->bus_flow_blocked;
+ for (fifo = BRCMF_FWS_FIFO_BCMC; fifo >= 0 && !fws->bus_flow_blocked;
fifo--) {
while ((fws->fifo_credit[fifo]) || ((!fws->bcmc_credit_check) &&
(fifo == BRCMF_FWS_FIFO_BCMC))) {
--
1.7.10.4
next prev parent reply other threads:[~2013-06-26 12:20 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-26 12:20 [PATCH 0/9] brcmfmac: platform data change and cleanup Arend van Spriel
2013-06-26 12:20 ` [PATCH 1/9] brcmfmac: simplify transmit path Arend van Spriel
2013-06-26 12:20 ` Arend van Spriel [this message]
2013-06-26 12:20 ` [PATCH 3/9] brcmfmac: remove SDIO_REQ_ASYNC flag Arend van Spriel
2013-06-26 12:20 ` [PATCH 4/9] brcmfmac: use unified dongle address preparation function Arend van Spriel
2013-06-26 12:20 ` [PATCH 5/9] brcmfmac: add broken scatter-gather DMA support Arend van Spriel
2013-06-26 12:20 ` [PATCH 6/9] brcmfmac: tag packet in the netdev transmit callback Arend van Spriel
2013-06-26 12:35 ` [PATCH V2 " Arend van Spriel
2013-06-26 12:20 ` [PATCH 7/9] brcmfmac: cleanup debug messages in brcmf_fws_hdrpush() Arend van Spriel
2013-06-26 12:20 ` [PATCH 8/9] brcmfmac: reduce firmware-signalling locking scope in rx path Arend van Spriel
2013-06-26 12:20 ` [PATCH 9/9] brcmfmac: remove code and comment for older kernel support Arend van Spriel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1372249222-4858-3-git-send-email-arend@broadcom.com \
--to=arend@broadcom.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).