From: Johannes Berg <johannes@sipsolutions.net>
To: "John W. Linville" <linville@tuxdriver.com>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [PATCH] iw: fix incorrect bit shifting in print_ht_mcs
Date: Wed, 26 Jun 2013 17:24:35 +0200 [thread overview]
Message-ID: <1372260275.13529.15.camel@jlt4.sipsolutions.net> (raw)
In-Reply-To: <1372259260-7061-1-git-send-email-linville@tuxdriver.com>
On Wed, 2013-06-26 at 11:07 -0400, John W. Linville wrote:
> From: "John W. Linville" <linville@tuxdriver.com>
>
> From a Coverity run on version 3.10:
>
> iw-3.10/util.c:569:result_independent_of_operands –
> "mcs[10] >> 8" is 0 regardless of the values of its operands. This occurs as the bitwise first operand of '&'.
>
> This seems more like what was intended...
Applied both, thanks.
johannes
prev parent reply other threads:[~2013-06-26 15:24 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-26 15:07 [PATCH] iw: fix incorrect bit shifting in print_ht_mcs John W. Linville
2013-06-26 15:24 ` Johannes Berg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1372260275.13529.15.camel@jlt4.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox