From: Johannes Berg <johannes@sipsolutions.net>
To: Simon Wunderlich <simon.wunderlich@s2003.tu-chemnitz.de>
Cc: linux-wireless@vger.kernel.org,
Mathias Kretschmer <mathias.kretschmer@fokus.fraunhofer.de>,
Simon Wunderlich <siwu@hrz.tu-chemnitz.de>
Subject: Re: [PATCHv4 03/18] mac80211: fix timing for 5 MHz and 10 MHz channels
Date: Thu, 27 Jun 2013 15:08:12 +0200 [thread overview]
Message-ID: <1372338492.8160.6.camel@jlt4.sipsolutions.net> (raw)
In-Reply-To: <1372337064-19254-4-git-send-email-siwu@hrz.tu-chemnitz.de>
On Thu, 2013-06-27 at 14:44 +0200, Simon Wunderlich wrote:
> +static inline int
> +ieee80211_chandef_get_divisor(struct cfg80211_chan_def *chandef)
> +{
> + switch (local->hw.conf.chandef.width) {
> + case NL80211_CHAN_WIDTH_5:
> + return 4;
> + case NL80211_CHAN_WIDTH_10:
> + return 2;
> + default:
> + return 1;
I wonder if instead of 'divisor' this should be expressed as a 'shift'.
With this variable divisor, the compiler can't know that it'll be 1/2/4,
so it has to actually use a real division when you use DIV_ROUND_UP. A
shift would be faster, it seems?
johannes
next prev parent reply other threads:[~2013-06-27 13:08 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-27 12:44 [PATCHv4 00/18] Add support for 5 and 10 MHz channels Simon Wunderlich
2013-06-27 12:44 ` [PATCHv4 01/18] nl80211: add scan width to bss and scan request Simon Wunderlich
2013-06-27 12:57 ` Johannes Berg
2013-06-27 16:07 ` Simon Wunderlich
2013-06-27 12:44 ` [PATCHv4 02/18] mac80211/rc80211: add chandef to rate initialization Simon Wunderlich
2013-06-27 12:59 ` Johannes Berg
2013-06-27 14:27 ` Simon Wunderlich
2013-06-27 14:30 ` Johannes Berg
2013-06-27 14:31 ` Johannes Berg
2013-06-27 15:29 ` Simon Wunderlich
2013-06-27 12:44 ` [PATCHv4 03/18] mac80211: fix timing for 5 MHz and 10 MHz channels Simon Wunderlich
2013-06-27 13:06 ` Johannes Berg
2013-06-27 13:08 ` Johannes Berg [this message]
2013-06-27 12:44 ` [PATCHv4 04/18] mac80211: select and adjust bitrates according to channel mode Simon Wunderlich
2013-06-27 12:44 ` [PATCHv4 05/18] cfg80211/mac80211: get mandatory rates based on rate flags Simon Wunderlich
2013-06-27 13:09 ` Johannes Berg
2013-06-27 12:44 ` [PATCHv4 06/18] cfg80211/mac80211: use reduced txpower for 5 and 10 MHz Simon Wunderlich
2013-06-27 12:44 ` [PATCHv4 07/18] mac80211: add radiotap flag and handling for 5/10 MHz Simon Wunderlich
2013-06-27 12:44 ` [PATCHv4 08/18] mac80211: allow scanning for 5/10 MHz channels in IBSS Simon Wunderlich
2013-06-27 13:12 ` Johannes Berg
2013-06-27 12:44 ` [PATCHv4 09/18] mac80211: return if IBSS chandef can not be used Simon Wunderlich
2013-06-27 12:44 ` [PATCHv4 10/18] nl80211: allow 5 and 10 MHz channels for IBSS Simon Wunderlich
2013-06-27 12:44 ` [PATCHv4 11/18] ath9k: always use SIFS times from OFDM for 5/10 MHz Simon Wunderlich
2013-06-27 12:44 ` [PATCHv4 12/18] ath9k: use chandef instead of channel_type Simon Wunderlich
2013-06-27 12:44 ` [PATCHv4 13/18] ath9k: report 5/10 MHz channels Simon Wunderlich
2013-06-27 12:44 ` [PATCHv4 14/18] ath9k: set 5/10 MHz supported channels and fix bitrate Simon Wunderlich
2013-06-27 12:44 ` [PATCHv4 15/18] ath9k: announce that ath9k supports 5/10 MHz Simon Wunderlich
2013-06-27 12:44 ` [PATCHv4 16/18] ath5k: report 5/10 MHz channels Simon Wunderlich
2013-06-27 12:44 ` [PATCHv4 17/18] ath5k: set 5/10 MHz supported channels and fix duration Simon Wunderlich
2013-06-27 12:44 ` [PATCHv4 18/18] ath5k: enable support for 5 MHz and 10 MHz channels Simon Wunderlich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1372338492.8160.6.camel@jlt4.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=mathias.kretschmer@fokus.fraunhofer.de \
--cc=simon.wunderlich@s2003.tu-chemnitz.de \
--cc=siwu@hrz.tu-chemnitz.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).