From: Luciano Coelho <coelho@ti.com>
To: Sam Bristow <sam.bristow@gmail.com>
Cc: Johannes Berg <johannes@sipsolutions.net>,
"David S. Miller" <davem@davemloft.net>,
<linux-wireless@vger.kernel.org>, <netdev@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] include: net: Add parameter desc to fix waring when generating docs
Date: Fri, 5 Jul 2013 01:43:10 +0300 [thread overview]
Message-ID: <1372977790.21065.141.camel@cumari.coelho.fi> (raw)
In-Reply-To: <1372975190-21117-1-git-send-email-sam.bristow@gmail.com>
On Fri, 2013-07-05 at 09:59 +1200, Sam Bristow wrote:
> 'make htmldocs' was generating a warning about a missing parameter description
> for gfp.
>
> Earlier patch was missing my signed-off-by line...
> Signed-off-by: Sam Bristow <sam.bristow@gmail.com>
> ---
You have a typo in the patch subject (it was not there in your previous
version ;).
Also, you shouldn't add explanations about the different versions of the
patch in the commit message (in you case the "Earlier patch was missing
my signed-off-by line..." text). If you want to add this kind of
comments, add it after the "---" under the Signed-of tags.
One more thing, it's a good idea to use [PATCH v2] when you're sending a
second version of the same patch. That can be easily done with git
format-patch (and also with git send-email) by using an argument like
this: --subject-prefix="PATCH v2"
--
Luca.
prev parent reply other threads:[~2013-07-04 22:43 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-04 21:59 [PATCH] include: net: Add parameter desc to fix waring when generating docs Sam Bristow
2013-07-04 22:43 ` Luciano Coelho [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1372977790.21065.141.camel@cumari.coelho.fi \
--to=coelho@ti.com \
--cc=davem@davemloft.net \
--cc=johannes@sipsolutions.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=sam.bristow@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox