From: Joe Perches <joe@perches.com>
To: John Greene <jogreene@redhat.com>
Cc: linville@tuxdriver.com, arend@broadcom.com,
linux-wireless@vger.kernel.org
Subject: Re: [PATCH] brcmsmac: Further reduce log spam from tx phy messages
Date: Mon, 15 Jul 2013 05:23:58 -0700 [thread overview]
Message-ID: <1373891038.2062.7.camel@joe-AO722> (raw)
In-Reply-To: <51E3E7F0.7050308@redhat.com>
On Mon, 2013-07-15 at 08:15 -0400, John Greene wrote:
> On 07/12/2013 02:00 PM, Joe Perches wrote:
> > On Fri, 2013-07-12 at 10:55 -0400, John Greene wrote:
[]
> > Just trivia:
> >> diff --git a/drivers/net/wireless/brcm80211/brcmsmac/ampdu.c b/drivers/net/wireless/brcm80211/brcmsmac/ampdu.c
> > []
> >> @@ -928,7 +928,7 @@ brcms_c_ampdu_dotxstatus_complete(struct ampdu_info *ampdu, struct scb *scb,
> > []
> >> - brcms_err(wlc->hw->d11core,
> >> + brcms_dbg_ht(wlc->hw->d11core,
> >> "%s: ampdu tx phy error (0x%x)\n",
> >> __func__, txs->phyerr);
> >
> > Please keep the indentation of the arguments of
> > the same statement aligned to the open parenthesis.
[]
> Thanks Joe. My oversight. I wish the checkpatch flagged this stuff.
It does if you use the --strict option.
prev parent reply other threads:[~2013-07-15 12:23 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-12 14:55 [PATCH] brcmsmac: Further reduce log spam from tx phy messages John Greene
2013-07-12 18:00 ` Joe Perches
2013-07-15 12:15 ` John Greene
2013-07-15 12:23 ` Joe Perches [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1373891038.2062.7.camel@joe-AO722 \
--to=joe@perches.com \
--cc=arend@broadcom.com \
--cc=jogreene@redhat.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).