From: Joe Perches <joe@perches.com>
To: Felix Fietkau <nbd@openwrt.org>
Cc: linux-wireless@vger.kernel.org, johannes@sipsolutions.net,
krzysiek@podlesie.net
Subject: Re: [PATCH 3.11] mac80211/minstrel: fix NULL pointer dereference issue
Date: Mon, 15 Jul 2013 06:31:55 -0700 [thread overview]
Message-ID: <1373895115.2062.12.camel@joe-AO722> (raw)
In-Reply-To: <51E3F0EA.3060603@openwrt.org>
On Mon, 2013-07-15 at 14:54 +0200, Felix Fietkau wrote:
> On 2013-07-15 2:50 PM, Joe Perches wrote:
> > On Mon, 2013-07-15 at 14:35 +0200, Felix Fietkau wrote:
> >> When priv_sta == NULL, mi->prev_sample is dereferenced too early. Move
> >> the assignment further down, after the rate_control_send_low call.
[]
> mi is set to priv_sta. It can be NULL. The case of priv_sta==NULL is
> caught by rate_control_send_low and causes it to bail out.
OK, thanks.
next prev parent reply other threads:[~2013-07-15 13:31 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-15 12:35 [PATCH 3.11] mac80211/minstrel: fix NULL pointer dereference issue Felix Fietkau
2013-07-15 12:50 ` Joe Perches
2013-07-15 12:54 ` Felix Fietkau
2013-07-15 13:31 ` Joe Perches [this message]
2013-07-15 17:32 ` Krzysztof Mazur
2013-07-16 14:48 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1373895115.2062.12.camel@joe-AO722 \
--to=joe@perches.com \
--cc=johannes@sipsolutions.net \
--cc=krzysiek@podlesie.net \
--cc=linux-wireless@vger.kernel.org \
--cc=nbd@openwrt.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).