Linux wireless drivers development
 help / color / mirror / Atom feed
From: Johannes Berg <johannes@sipsolutions.net>
To: Michal Kazior <michal.kazior@tieto.com>
Cc: linux-wireless@vger.kernel.org, ath10k@lists.infradead.org
Subject: Re: [RFC 1/3] nl/cfg80211: add chan_time for scan request
Date: Thu, 01 Aug 2013 09:40:45 +0200	[thread overview]
Message-ID: <1375342845.8608.8.camel@jlt4.sipsolutions.net> (raw)
In-Reply-To: <1375087158-22077-2-git-send-email-michal.kazior@tieto.com>

On Mon, 2013-07-29 at 10:39 +0200, Michal Kazior wrote:

> + * @NL80211_ATTR_SCAN_CHAN_TIME: Specifies how many msec should a driver spend
> + *	on each channel during scanning. This is optional and the default is
> + *	leave the decision up to the driver. This setting may, but preferrably

typo: preferably :)

> + *	shouldn't, be ignored by driver.

This seems a bit iffy - you don't differentiate between active/passive
scans?

Also maybe there should be a bit saying "I support scan timing" or even
the min/max times?

This also interferes a bit with some other scan optimisations that could
be done at a low firmware level, so I think we should be careful and
actually say that this is really more intended for measurement use cases
and not for normal scans?

Or maybe we should have a separate measurement command with similar
semantics? This all doesn't seem very clear to me yet :)

johannes


  reply	other threads:[~2013-08-01  7:40 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-29  8:39 [RFC 0/3] introduce chan_time parameter to scan request Michal Kazior
2013-07-29  8:39 ` [RFC 1/3] nl/cfg80211: add chan_time for " Michal Kazior
2013-08-01  7:40   ` Johannes Berg [this message]
2013-08-01  9:14     ` Michal Kazior
2013-08-02 11:25       ` Johannes Berg
2013-08-02 11:52         ` Michal Kazior
2013-08-02 13:01           ` Johannes Berg
     [not found]         ` <CACA4iOrZSARKFVFx1E2QPyH=xZzQp+VoyPu_tuFWgBR3tQwOmw@mail.gmail.com>
2013-08-02 12:56           ` Sunil Dutt
2013-07-29  8:39 ` [RFC 2/3] mac80211: add support for scan chan_time parameter Michal Kazior
2013-07-29  8:39 ` [RFC 3/3] ath10k: respect chan_time parameter in scan request Michal Kazior
2013-08-01  7:36 ` [RFC 0/3] introduce chan_time parameter to " Johannes Berg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1375342845.8608.8.camel@jlt4.sipsolutions.net \
    --to=johannes@sipsolutions.net \
    --cc=ath10k@lists.infradead.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=michal.kazior@tieto.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox