From: Johannes Berg <johannes@sipsolutions.net>
To: Eliad Peller <eliad@wizery.com>
Cc: "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH] mac80211: add control port protocol TX control flag
Date: Tue, 06 Aug 2013 13:36:56 +0200 [thread overview]
Message-ID: <1375789016.8219.14.camel@jlt4.sipsolutions.net> (raw)
In-Reply-To: <CAB3XZEeYvi=i5crLsMKNhgbctPhU9BjEF=DTsHdickssRM480A@mail.gmail.com> (sfid-20130806_124006_577783_7F634B61)
On Tue, 2013-08-06 at 13:40 +0300, Eliad Peller wrote:
> > static inline bool iwl_trace_data(struct sk_buff *skb)
> > {
> > struct ieee80211_hdr *hdr = (void *)skb->data;
> > + struct ieee80211_tx_info *info = IEEE80211_SKB_CB(skb);
> >
> > if (ieee80211_is_data(hdr->frame_control))
> > - return skb->protocol != cpu_to_be16(ETH_P_PAE);
> > + return info->control.flags & IEEE80211_TX_CTRL_PORT_CTRL_PROTO;
> > return false;
> > }
> this looks reversed...
Good catch, thanks.
johannes
next prev parent reply other threads:[~2013-08-06 11:37 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-06 9:57 [PATCH] mac80211: add control port protocol TX control flag Johannes Berg
2013-08-06 10:40 ` Eliad Peller
2013-08-06 11:36 ` Johannes Berg [this message]
2013-08-06 20:15 ` Kalle Valo
2013-08-12 12:09 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1375789016.8219.14.camel@jlt4.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=eliad@wizery.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).