linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Johannes Berg <johannes@sipsolutions.net>
To: Johan Almbladh <ja@anyfi.net>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [RFC] mac80211: add support for split-MAC implementations
Date: Fri, 09 Aug 2013 15:07:51 +0200	[thread overview]
Message-ID: <1376053671.8355.4.camel@jlt4.sipsolutions.net> (raw)
In-Reply-To: <1375968116-24331-1-git-send-email-ja@anyfi.net> (sfid-20130808_152319_898268_ED7ABE6E)

On Thu, 2013-08-08 at 15:21 +0200, Johan Almbladh wrote:
> This patch enables power save processing for encrypted frames even if the
> encryption key is not set. This is a requirement when implementing split-MAC
> systems like Anyfi.net [1] and CAPWAP [2] on mac80211 using monitor frame
> injection and reception. 

I have no idea what these are, nor do I actually want to care much...
You presumably use Felix's active monitor mode?

> The mac80211 RX handlers are reordered slightly so
> that the power save handler is invoked before the decryption handler.
> 
> The patch is minimal in the sense that it provides the required functionality
> with a minimal change, but I am open to suggestions if this change is too
> intrusive. Please let me know what you think.

I think you should ask yourself if this makes sense in the normal wifi
context... :-)

It actually seems like it *does* make sense, so it should have an
appropriate description for that, but I'm a bit worried about IBSS in
sta_process.

Also I've tried to keep the code in the file sequential, so this patch
should be moving ieee80211_rx_h_decrypt() itself as well.

johannes


  reply	other threads:[~2013-08-09 13:07 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-08 13:21 [RFC] mac80211: add support for split-MAC implementations Johan Almbladh
2013-08-09 13:07 ` Johannes Berg [this message]
2013-08-10 11:31   ` Johan Almbladh
2013-08-11 20:19     ` Johan Almbladh
2013-08-12 16:01       ` Johannes Berg
2013-08-12 18:04         ` Antonio Quartulli
2013-08-14 13:29         ` [PATCHv2 1/2] mac80211: perform power save processing before decryption Johan Almbladh
2013-08-14 13:29           ` [PATCHv2 2/2] mac80211: non-functional change of rx handler location Johan Almbladh
2013-08-16 10:19             ` Johannes Berg
2013-08-15  6:08           ` [PATCHv2 1/2] mac80211: perform power save processing before decryption Kalle Valo
2013-08-15  6:58             ` Johan Almbladh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1376053671.8355.4.camel@jlt4.sipsolutions.net \
    --to=johannes@sipsolutions.net \
    --cc=ja@anyfi.net \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).