From: Johannes Berg <johannes@sipsolutions.net>
To: Simon Wunderlich <simon.wunderlich@s2003.tu-chemnitz.de>
Cc: linux-wireless@vger.kernel.org,
Mathias Kretschmer <mathias.kretschmer@fokus.fraunhofer.de>,
Simon Wunderlich <siwu@hrz.tu-chemnitz.de>
Subject: Re: [PATCHv2 2/6] mac80211: split off channel switch parsing function
Date: Fri, 16 Aug 2013 12:25:16 +0200 [thread overview]
Message-ID: <1376648716.15299.5.camel@jlt4.sipsolutions.net> (raw)
In-Reply-To: <1376058920-17779-3-git-send-email-siwu@hrz.tu-chemnitz.de>
On Fri, 2013-08-09 at 16:35 +0200, Simon Wunderlich wrote:
> --- a/net/mac80211/mlme.c
> +++ b/net/mac80211/mlme.c
> @@ -981,54 +981,35 @@ static void ieee80211_chswitch_timer(unsigned long data)
> ieee80211_queue_work(&sdata->local->hw, &sdata->u.mgd.chswitch_work);
> }
>
> -static void
> -ieee80211_sta_process_chanswitch(struct ieee80211_sub_if_data *sdata,
> - u64 timestamp, struct ieee802_11_elems *elems,
> - bool beacon)
> +int ieee80211_parse_ch_switch_ie(struct ieee80211_sub_if_data *sdata,
I think you should also move this function out of mlme.c, maybe the
(almost empty) spectmgmt.c file?
> + struct ieee802_11_elems *elems, bool beacon,
> + enum ieee80211_band current_band,
> + u32 sta_flags,
Passing sta_flags seems a bit odd - I understand the motivation but I
think it would be worthwhile to document (maybe in the kernel-doc in the
header file) which flags are used.
johannes
next prev parent reply other threads:[~2013-08-16 10:25 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-09 14:35 [PATCHv2 0/6] add IBSS channel switch announcement support Simon Wunderlich
2013-08-09 14:35 ` [PATCHv2 1/6] cfg80211: export cfg80211_chandef_dfs_required Simon Wunderlich
2013-08-09 14:35 ` [PATCHv2 2/6] mac80211: split off channel switch parsing function Simon Wunderlich
2013-08-16 10:25 ` Johannes Berg [this message]
2013-08-09 14:35 ` [PATCHv2 3/6] mac80211: move ibss presp generation in own function Simon Wunderlich
2013-08-16 10:26 ` Johannes Berg
2013-08-09 14:35 ` [PATCHv2 4/6] mac80211: add support for CSA in IBSS mode Simon Wunderlich
2013-08-16 10:33 ` Johannes Berg
2013-08-16 13:36 ` Simon Wunderlich
2013-08-19 10:35 ` Johannes Berg
2013-08-09 14:35 ` [PATCHv2 5/6] mac80211: send a CSA action frame when changing channel Simon Wunderlich
2013-08-09 14:35 ` [PATCHv2 6/6] nl80211: enable IBSS support for channel switch announcements Simon Wunderlich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1376648716.15299.5.camel@jlt4.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=mathias.kretschmer@fokus.fraunhofer.de \
--cc=simon.wunderlich@s2003.tu-chemnitz.de \
--cc=siwu@hrz.tu-chemnitz.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).