Linux wireless drivers development
 help / color / mirror / Atom feed
From: Johannes Berg <johannes@sipsolutions.net>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: David Miller <davem@davemloft.net>,
	John Linville <linville@tuxdriver.com>,
	Linux Wireless List <linux-wireless@vger.kernel.org>
Subject: Re: Wireless disassociations..
Date: Mon, 19 Aug 2013 17:50:30 +0200	[thread overview]
Message-ID: <1376927430.14734.15.camel@jlt4.sipsolutions.net> (raw)
In-Reply-To: <CA+55aFwSF9e5hHMQgmbmoyPm0Z-YJK43ycgnB8ZkXtsL6xSaTA@mail.gmail.com> (sfid-20130819_174540_576480_952E41DA)

On Mon, 2013-08-19 at 08:45 -0700, Linus Torvalds wrote:
> Is anybody following this bugzilla?
> 
>    https://bugzilla.kernel.org/show_bug.cgi?id=60690
> 
> it has a bisection in it, and a patch?

It just came back to me and I commented on it - I think/hope that
commits
ddfe49b42d8ad4bfdf92d63d4a74f162660d878d (mac80211: continue using disabled channels while connected)
5cdaed1e878d723d56d04ae0be1738124acf9f46 (mac80211: ignore HT primary channel while connected)

will have fixed this case as well as
https://bugzilla.redhat.com/show_bug.cgi?id=981445

> The patch is a bit odd, but quite frankly, the current values for
> IEEE80211_HT_PARAM_CHA_SEC_xxx are (a) odd and (b) used very oddly
> too. Is it possible that that 0x03 really should be 0x02?

The patch basically removes the code, the value really should be 0x3 as
defined by the 802.11 spec table 8-130:

        Set to 1 (SCA) if the secondary channel is secondary channel
        relative to above the primary channel the primary channel.
        
        Set to 3 (SCB) if the secondary channel is below the primary
        channel
        
        Set to 0 (SCN) if no secondary channel is present
        
        The value 2 is reserved

(it's a two-bit field)

johannes


      reply	other threads:[~2013-08-19 15:50 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-19 15:45 Wireless disassociations Linus Torvalds
2013-08-19 15:50 ` Johannes Berg [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1376927430.14734.15.camel@jlt4.sipsolutions.net \
    --to=johannes@sipsolutions.net \
    --cc=davem@davemloft.net \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox