From: Johannes Berg <johannes@sipsolutions.net>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: Florian Fainelli <f.fainelli@gmail.com>,
Eric Dumazet <eric.dumazet@gmail.com>,
Ben Hutchings <bhutchings@solarflare.com>,
netdev <netdev@vger.kernel.org>,
linux-wireless@vger.kernel.org
Subject: Re: changing dev->needed_headroom/needed_tailroom?
Date: Tue, 20 Aug 2013 18:24:57 +0200 [thread overview]
Message-ID: <1377015897.13829.16.camel@jlt4.sipsolutions.net> (raw)
In-Reply-To: <20130820092013.6ca909e2@nehalam.linuxnetplumber.net> (sfid-20130820_182019_441833_A12DE7FE)
On Tue, 2013-08-20 at 09:20 -0700, Stephen Hemminger wrote:
> All code must check for needed headroom first, and copy packet
> if space is not available. Since excess headroom is always safe,
> most devices just always use the same worst case headroom.
>
> Even with your changes this will still be necessary since packets will
> be still in flight while features change.
I agree, it will always be necessary. I guess the question boils down to
whether/what N bytes headroom more or less actually make a difference.
The wireless stack currently sets needed_headroom to 34 or so I think,
but I will need to increase by 8 which was why I had this question to
start with. However, those 34 are an absolute worst case - in most cases
it's much less...
So I suppose the other question we should ask is will increasing from
~34 to ~42 make a significant different that it's worth thinking about
avoiding it in the common cases at all?
johannes
next prev parent reply other threads:[~2013-08-20 16:25 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-26 14:50 changing dev->needed_headroom/needed_tailroom? Johannes Berg
2013-08-02 8:55 ` Ben Hutchings
2013-08-02 13:11 ` Eric Dumazet
2013-08-05 14:00 ` Johannes Berg
2013-08-20 10:00 ` Florian Fainelli
2013-08-20 16:20 ` Stephen Hemminger
2013-08-20 16:24 ` Johannes Berg [this message]
2013-08-20 16:29 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1377015897.13829.16.camel@jlt4.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=bhutchings@solarflare.com \
--cc=eric.dumazet@gmail.com \
--cc=f.fainelli@gmail.com \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).