From: Joe Perches <joe@perches.com>
To: Eugene Krasnikov <k.eugene.e@gmail.com>
Cc: linux-wireless@vger.kernel.org, wcn36xx@lists.infradead.org
Subject: Re: [PATCH 09/16] wcn36xx: Add smd.c
Date: Tue, 20 Aug 2013 11:12:13 -0700 [thread overview]
Message-ID: <1377022333.2016.59.camel@joe-AO722> (raw)
In-Reply-To: <1377020479-16935-10-git-send-email-k.eugene.e@gmail.com>
On Tue, 2013-08-20 at 19:41 +0200, Eugene Krasnikov wrote:
> diff --git a/drivers/net/wireless/ath/wcn36xx/smd.c b/drivers/net/wireless/ath/wcn36xx/smd.c
[]
> +int wcn36xx_smd_load_nv(struct wcn36xx *wcn)
> +{
[]
> + /* Add NV body itself */
> + /* Rework me */
> + memcpy(wcn->smd_buf + sizeof(msg_body),
> + (void *)(&nv_d->table) + fm_offset,
> + msg_body.nv_img_buffer_size);
Does this really do what you want?
Perhaps it should be:
memcpy(wcn->smd_buf + sizeof(msg_body),
((void *)&nv_d->table) + fm_offset,
msg_body.nv_img_buffer_size);
next prev parent reply other threads:[~2013-08-20 18:12 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-20 17:41 [PATCH 00/16] wcn36xx: mac80211 driver for Qualcomm WCN3660/WCN3680 hardware Eugene Krasnikov
2013-08-20 17:41 ` [PATCH 01/16] wcn36xx: Add main.c Eugene Krasnikov
2013-08-20 20:59 ` Johannes Berg
2013-08-21 8:36 ` Eugene Krasnikov
2013-08-21 8:39 ` Johannes Berg
2013-08-21 9:00 ` Eugene Krasnikov
2013-08-20 17:41 ` [PATCH 02/16] wcn36xx: Add debug.c Eugene Krasnikov
2013-08-20 17:41 ` [PATCH 03/16] wcn36xx: Add debug.h Eugene Krasnikov
2013-08-20 17:41 ` [PATCH 04/16] wcn36xx: Add dxe.c Eugene Krasnikov
2013-08-20 17:41 ` [PATCH 05/16] wcn36xx: Add dxe.h Eugene Krasnikov
2013-08-20 17:41 ` [PATCH 06/16] wcn36xx: Add hal.h Eugene Krasnikov
2013-08-20 17:41 ` [PATCH 07/16] wcn36xx: Add pmc.c Eugene Krasnikov
2013-08-20 17:41 ` [PATCH 08/16] wcn36xx: Add pmc.h Eugene Krasnikov
2013-08-20 17:41 ` [PATCH 09/16] wcn36xx: Add smd.c Eugene Krasnikov
2013-08-20 18:12 ` Joe Perches [this message]
2013-08-21 7:58 ` Eugene Krasnikov
2013-08-21 8:15 ` Johannes Berg
2013-08-21 8:49 ` Eugene Krasnikov
2013-08-21 11:20 ` Joe Perches
2013-08-20 17:41 ` [PATCH 10/16] wcn36xx: Add smd.h Eugene Krasnikov
2013-08-20 17:41 ` [PATCH 11/16] wcn36xx: Add txrx.c Eugene Krasnikov
2013-08-20 21:01 ` Johannes Berg
2013-08-21 8:39 ` Eugene Krasnikov
2013-08-20 21:03 ` Johannes Berg
2013-08-21 8:44 ` Eugene Krasnikov
2013-08-20 17:41 ` [PATCH 12/16] wcn36xx: Add txrx.h Eugene Krasnikov
2013-08-20 17:41 ` [PATCH 13/16] wcn36xx: Add wcn36xx.h Eugene Krasnikov
2013-08-20 18:04 ` Joe Perches
2013-08-21 7:55 ` Eugene Krasnikov
2013-08-20 17:41 ` [PATCH 14/16] wcn36xx: Add Makefile Eugene Krasnikov
2013-08-20 17:41 ` [PATCH 15/16] wcn36xx: Add Kconfig Eugene Krasnikov
2013-08-20 17:41 ` [PATCH 16/16] wcn36xx: Add wcn36xx to ath Makefile and Kconfig Eugene Krasnikov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1377022333.2016.59.camel@joe-AO722 \
--to=joe@perches.com \
--cc=k.eugene.e@gmail.com \
--cc=linux-wireless@vger.kernel.org \
--cc=wcn36xx@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox