From: Joe Perches <joe@perches.com>
To: Kalle Valo <kvalo@qca.qualcomm.com>
Cc: "Luis R. Rodriguez" <rodrigue@qca.qualcomm.com>,
linux-wireless <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH 2/2] qca-swiss-army-knife: add ath10k trace-cmd plugin
Date: Wed, 04 Sep 2013 22:38:51 -0700 [thread overview]
Message-ID: <1378359531.1944.3.camel@joe-AO722> (raw)
In-Reply-To: <87sixjrhan.fsf@kamboji.qca.qualcomm.com>
On Thu, 2013-09-05 at 08:03 +0300, Kalle Valo wrote:
> Joe Perches <joe@perches.com> writes:
>
> > On Thu, 2013-09-05 at 07:49 +0300, Kalle Valo wrote:
> >> "Luis R. Rodriguez" <rodrigue@qca.qualcomm.com> writes:
> >> > I just removed 3 trailing spaces on the 2 patches. One had two
> >> > trailing spaces, the last patch had one.
> >>
> >> Oh, sorry about that. Any ideas how I could check for those myself?
> >
> > scripts/checkpatch.pl <patch>
>
> Checkpatch works also with trace-cmd plugins written in python?
Don't see why not.
Trailing spaces are trailing spaces and the trailing
space test is done way before looking at file type
specific tests.
> > git am <patch>
>
> Yeah, I guess I could do that, it's just a bit inconvienient.
scripting a git am script for a patch
set is just a for loop...
You could also use scripts/cleanpatch
next prev parent reply other threads:[~2013-09-05 5:38 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-19 19:11 [PATCH 1/2] qca-swiss-army-knife: add ath6kl trace-cmd plugin Kalle Valo
2013-08-19 19:11 ` [PATCH 2/2] qca-swiss-army-knife: add ath10k " Kalle Valo
2013-09-04 18:57 ` Luis R. Rodriguez
2013-09-05 4:49 ` Kalle Valo
2013-09-05 4:57 ` Joe Perches
2013-09-05 5:03 ` Kalle Valo
2013-09-05 5:38 ` Joe Perches [this message]
2013-09-05 4:57 ` Julian Calaby
2013-09-05 5:08 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1378359531.1944.3.camel@joe-AO722 \
--to=joe@perches.com \
--cc=kvalo@qca.qualcomm.com \
--cc=linux-wireless@vger.kernel.org \
--cc=rodrigue@qca.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox