* [PATCH 1/2] NFC: Remove redundant dev_set_drvdata
@ 2013-09-20 9:00 Sachin Kamat
2013-09-20 9:00 ` [PATCH 2/2] NFC: pn533: Staticize local symbols Sachin Kamat
2013-09-20 15:30 ` [PATCH 1/2] NFC: Remove redundant dev_set_drvdata Samuel Ortiz
0 siblings, 2 replies; 5+ messages in thread
From: Sachin Kamat @ 2013-09-20 9:00 UTC (permalink / raw)
To: linux-nfc
Cc: linux-wireless, sameo, lauro.venancio, aloisio.almeida,
sachin.kamat, Ilan Elias
Driver core sets driver data to NULL upon failure or remove.
Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
Cc: Ilan Elias <ilane@ti.com>
---
Series compile tested.
---
drivers/nfc/nfcwilink.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/nfc/nfcwilink.c b/drivers/nfc/nfcwilink.c
index 59f95d8..9b1d91ee 100644
--- a/drivers/nfc/nfcwilink.c
+++ b/drivers/nfc/nfcwilink.c
@@ -578,8 +578,6 @@ static int nfcwilink_remove(struct platform_device *pdev)
nci_unregister_device(ndev);
nci_free_device(ndev);
- dev_set_drvdata(&pdev->dev, NULL);
-
return 0;
}
--
1.7.9.5
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH 2/2] NFC: pn533: Staticize local symbols
2013-09-20 9:00 [PATCH 1/2] NFC: Remove redundant dev_set_drvdata Sachin Kamat
@ 2013-09-20 9:00 ` Sachin Kamat
2013-09-20 15:31 ` Samuel Ortiz
2013-09-20 15:30 ` [PATCH 1/2] NFC: Remove redundant dev_set_drvdata Samuel Ortiz
1 sibling, 1 reply; 5+ messages in thread
From: Sachin Kamat @ 2013-09-20 9:00 UTC (permalink / raw)
To: linux-nfc
Cc: linux-wireless, sameo, lauro.venancio, aloisio.almeida,
sachin.kamat
Local symbols used only in this file are made static.
Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
---
drivers/nfc/pn533.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/nfc/pn533.c b/drivers/nfc/pn533.c
index 5df730b..9f12a75 100644
--- a/drivers/nfc/pn533.c
+++ b/drivers/nfc/pn533.c
@@ -2793,12 +2793,12 @@ static int pn533_rf_field(struct nfc_dev *nfc_dev, u8 rf)
return rc;
}
-int pn533_dev_up(struct nfc_dev *nfc_dev)
+static int pn533_dev_up(struct nfc_dev *nfc_dev)
{
return pn533_rf_field(nfc_dev, 1);
}
-int pn533_dev_down(struct nfc_dev *nfc_dev)
+static int pn533_dev_down(struct nfc_dev *nfc_dev)
{
return pn533_rf_field(nfc_dev, 0);
}
--
1.7.9.5
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH 2/2] NFC: pn533: Staticize local symbols
2013-09-20 9:00 ` [PATCH 2/2] NFC: pn533: Staticize local symbols Sachin Kamat
@ 2013-09-20 15:31 ` Samuel Ortiz
0 siblings, 0 replies; 5+ messages in thread
From: Samuel Ortiz @ 2013-09-20 15:31 UTC (permalink / raw)
To: Sachin Kamat; +Cc: linux-nfc, linux-wireless, lauro.venancio, aloisio.almeida
Hi Sachin,
On Fri, Sep 20, 2013 at 02:30:41PM +0530, Sachin Kamat wrote:
> Local symbols used only in this file are made static.
>
> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
> ---
> drivers/nfc/pn533.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Applied as well, thanks.
Cheers,
Samuel.
--
Intel Open Source Technology Centre
http://oss.intel.com/
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 1/2] NFC: Remove redundant dev_set_drvdata
2013-09-20 9:00 [PATCH 1/2] NFC: Remove redundant dev_set_drvdata Sachin Kamat
2013-09-20 9:00 ` [PATCH 2/2] NFC: pn533: Staticize local symbols Sachin Kamat
@ 2013-09-20 15:30 ` Samuel Ortiz
1 sibling, 0 replies; 5+ messages in thread
From: Samuel Ortiz @ 2013-09-20 15:30 UTC (permalink / raw)
To: Sachin Kamat
Cc: linux-nfc, linux-wireless, lauro.venancio, aloisio.almeida,
Ilan Elias
Hi Sachin,
On Fri, Sep 20, 2013 at 02:30:40PM +0530, Sachin Kamat wrote:
> Driver core sets driver data to NULL upon failure or remove.
>
> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
> Cc: Ilan Elias <ilane@ti.com>
> ---
> Series compile tested.
> ---
> drivers/nfc/nfcwilink.c | 2 --
> 1 file changed, 2 deletions(-)
Applied, thanks.
Cheers,
Samuel.
--
Intel Open Source Technology Centre
http://oss.intel.com/
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH 2/2] NFC: pn533: Staticize local symbols
@ 2013-08-12 6:40 Jingoo Han
0 siblings, 0 replies; 5+ messages in thread
From: Jingoo Han @ 2013-08-12 6:40 UTC (permalink / raw)
To: 'Lauro Ramos Venancio'
Cc: 'Aloisio Almeida Jr', 'Samuel Ortiz',
linux-wireless, linux-nfc, 'Waldemar Rymarkiewicz',
Thierry Escande, 'Olivier Guiter', Jingoo Han
These local symbols are used only in this file.
Fix the following sparse warnings:
drivers/nfc/pn533.c:2576:5: warning: symbol 'pn533_dev_up' was not declared. Should it be static?
drivers/nfc/pn533.c:2581:5: warning: symbol 'pn533_dev_down' was not declared. Should it be static?
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
drivers/nfc/pn533.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/nfc/pn533.c b/drivers/nfc/pn533.c
index daf92ac..1746225 100644
--- a/drivers/nfc/pn533.c
+++ b/drivers/nfc/pn533.c
@@ -2573,12 +2573,12 @@ static int pn533_rf_field(struct nfc_dev *nfc_dev, u8 rf)
return rc;
}
-int pn533_dev_up(struct nfc_dev *nfc_dev)
+static int pn533_dev_up(struct nfc_dev *nfc_dev)
{
return pn533_rf_field(nfc_dev, 1);
}
-int pn533_dev_down(struct nfc_dev *nfc_dev)
+static int pn533_dev_down(struct nfc_dev *nfc_dev)
{
return pn533_rf_field(nfc_dev, 0);
}
--
1.7.10.4
^ permalink raw reply related [flat|nested] 5+ messages in thread
end of thread, other threads:[~2013-09-20 15:31 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-09-20 9:00 [PATCH 1/2] NFC: Remove redundant dev_set_drvdata Sachin Kamat
2013-09-20 9:00 ` [PATCH 2/2] NFC: pn533: Staticize local symbols Sachin Kamat
2013-09-20 15:31 ` Samuel Ortiz
2013-09-20 15:30 ` [PATCH 1/2] NFC: Remove redundant dev_set_drvdata Samuel Ortiz
-- strict thread matches above, loose matches on Subject: below --
2013-08-12 6:40 [PATCH 2/2] NFC: pn533: Staticize local symbols Jingoo Han
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).