From: Bing Zhao <bzhao@marvell.com>
To: <linux-bluetooth@vger.kernel.org>
Cc: Marcel Holtmann <marcel@holtmann.org>,
Gustavo Padovan <gustavo@padovan.org>,
Johan Hedberg <johan.hedberg@gmail.com>,
<linux-wireless@vger.kernel.org>,
Mike Frysinger <vapier@chromium.org>,
Hyuckjoo Lee <hyuckjoo.lee@samsung.com>,
Bing Zhao <bzhao@marvell.com>,
Amitkumar Karwar <akarwar@marvell.com>
Subject: [PATCH v5 1/2] Bluetooth: btmrvl: add setup handler
Date: Fri, 20 Sep 2013 15:21:06 -0700 [thread overview]
Message-ID: <1379715667-22424-1-git-send-email-bzhao@marvell.com> (raw)
From: Amitkumar Karwar <akarwar@marvell.com>
Move initialization code to hdev's setup handler. New flag
setup_done is added to make sure that initialization is done only
during driver load time. Our firmware doesn't expect
re-initialization later when interface is re-enabled.
Signed-off-by: Amitkumar Karwar <akarwar@marvell.com>
Signed-off-by: Bing Zhao <bzhao@marvell.com>
---
v5: make use of hdev's setup handler (Marcel Holtmann)
drivers/bluetooth/btmrvl_drv.h | 1 +
drivers/bluetooth/btmrvl_main.c | 23 +++++++++++++++++++++--
drivers/bluetooth/btmrvl_sdio.c | 6 ------
3 files changed, 22 insertions(+), 8 deletions(-)
diff --git a/drivers/bluetooth/btmrvl_drv.h b/drivers/bluetooth/btmrvl_drv.h
index 27068d1..e776b8b 100644
--- a/drivers/bluetooth/btmrvl_drv.h
+++ b/drivers/bluetooth/btmrvl_drv.h
@@ -68,6 +68,7 @@ struct btmrvl_adapter {
wait_queue_head_t cmd_wait_q;
u8 cmd_complete;
bool is_suspended;
+ bool setup_done;
};
struct btmrvl_private {
diff --git a/drivers/bluetooth/btmrvl_main.c b/drivers/bluetooth/btmrvl_main.c
index 9a9f518..e352f8e 100644
--- a/drivers/bluetooth/btmrvl_main.c
+++ b/drivers/bluetooth/btmrvl_main.c
@@ -479,6 +479,27 @@ static int btmrvl_open(struct hci_dev *hdev)
return 0;
}
+static int btmrvl_setup(struct hci_dev *hdev)
+{
+ struct btmrvl_private *priv = hci_get_drvdata(hdev);
+ struct btmrvl_adapter *adapter = priv->adapter;
+
+ if (adapter->setup_done)
+ return 0;
+
+ btmrvl_send_module_cfg_cmd(priv, MODULE_BRINGUP_REQ);
+
+ priv->btmrvl_dev.psmode = 1;
+ btmrvl_enable_ps(priv);
+
+ priv->btmrvl_dev.gpio_gap = 0xffff;
+ btmrvl_send_hscfg_cmd(priv);
+
+ adapter->setup_done = true;
+
+ return 0;
+}
+
/*
* This function handles the event generated by firmware, rx data
* received from firmware, and tx data sent from kernel.
@@ -572,8 +592,7 @@ int btmrvl_register_hdev(struct btmrvl_private *priv)
hdev->flush = btmrvl_flush;
hdev->send = btmrvl_send_frame;
hdev->ioctl = btmrvl_ioctl;
-
- btmrvl_send_module_cfg_cmd(priv, MODULE_BRINGUP_REQ);
+ hdev->setup = btmrvl_setup;
hdev->dev_type = priv->btmrvl_dev.dev_type;
diff --git a/drivers/bluetooth/btmrvl_sdio.c b/drivers/bluetooth/btmrvl_sdio.c
index 75c2626..c526915 100644
--- a/drivers/bluetooth/btmrvl_sdio.c
+++ b/drivers/bluetooth/btmrvl_sdio.c
@@ -1046,12 +1046,6 @@ static int btmrvl_sdio_probe(struct sdio_func *func,
goto disable_host_int;
}
- priv->btmrvl_dev.psmode = 1;
- btmrvl_enable_ps(priv);
-
- priv->btmrvl_dev.gpio_gap = 0xffff;
- btmrvl_send_hscfg_cmd(priv);
-
return 0;
disable_host_int:
--
1.7.3.4
next reply other threads:[~2013-09-20 22:21 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-20 22:21 Bing Zhao [this message]
2013-09-20 22:21 ` [PATCH v5 2/2] Bluetooth: btmrvl: add calibration data download support Bing Zhao
2013-09-21 17:03 ` Marcel Holtmann
2013-09-23 19:35 ` Bing Zhao
2013-09-24 4:21 ` Marcel Holtmann
2013-09-24 19:22 ` Bing Zhao
2013-09-24 19:43 ` Marcel Holtmann
2013-09-24 19:54 ` Bing Zhao
2013-09-21 17:00 ` [PATCH v5 1/2] Bluetooth: btmrvl: add setup handler Marcel Holtmann
2013-09-23 19:18 ` Bing Zhao
2013-09-24 4:23 ` Marcel Holtmann
2013-09-24 19:04 ` Bing Zhao
2013-09-24 19:30 ` Johan Hedberg
2013-09-24 19:42 ` Bing Zhao
2013-09-25 23:23 ` Bing Zhao
2013-09-26 1:45 ` Marcel Holtmann
2013-10-01 11:13 ` Johan Hedberg
2013-10-01 16:23 ` Bing Zhao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1379715667-22424-1-git-send-email-bzhao@marvell.com \
--to=bzhao@marvell.com \
--cc=akarwar@marvell.com \
--cc=gustavo@padovan.org \
--cc=hyuckjoo.lee@samsung.com \
--cc=johan.hedberg@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=marcel@holtmann.org \
--cc=vapier@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox