From: Johannes Berg <johannes@sipsolutions.net>
To: Sreenath Sharma <sreenats@broadcom.com>
Cc: linux-wireless@vger.kernel.org, j@w1.fi
Subject: Re: [PATCH] cfg80211: Provision to pass probe response ie along with remain on channel request
Date: Thu, 26 Sep 2013 12:58:38 +0200 [thread overview]
Message-ID: <1380193118.14806.0.camel@jlt4.sipsolutions.net> (raw)
In-Reply-To: <20130926073414.GA15283@sreenath-Precision-M4700>
On Thu, 2013-09-26 at 13:04 +0530, Sreenath Sharma wrote:
> The probe response ie should be set in driver before the listen state
> for a listen only P2P device. Right now probe response ie is set using
> driver specific private command implementations. This commit enhances the
> remain_on_channel command handler to pass probe response ie along with
> rest of the arguments.
>
> Another approach is the addition of a new nl80211 command specific to pass
> ies to driver. This will give more flexibilty to upper layer.
Umm, no, nack. this is totally bogus. You're implementing something like
"P2P-listen offload" but hiding it inside the "remain-on-channel"
command. That's totally the wrong way to go about it.
NACK. Not going to accept this.
johannes
prev parent reply other threads:[~2013-09-26 10:58 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-26 7:34 [PATCH] cfg80211: Provision to pass probe response ie along with remain on channel request Sreenath Sharma
2013-09-26 10:58 ` Johannes Berg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1380193118.14806.0.camel@jlt4.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=j@w1.fi \
--cc=linux-wireless@vger.kernel.org \
--cc=sreenats@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox