From: Johannes Berg <johannes@sipsolutions.net>
To: Felix Fietkau <nbd@openwrt.org>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [PATCH 3.12 2/2] mac80211: update sta->last_rx on acked tx frames
Date: Mon, 30 Sep 2013 12:34:21 +0200 [thread overview]
Message-ID: <1380537261.14467.8.camel@jlt4.sipsolutions.net> (raw)
In-Reply-To: <52494861.8010007@openwrt.org>
On Mon, 2013-09-30 at 11:46 +0200, Felix Fietkau wrote:
> On 2013-09-30 11:10 AM, Johannes Berg wrote:
> > On Sun, 2013-09-29 at 21:39 +0200, Felix Fietkau wrote:
> >> When clients are idle for too long, hostapd sends nullfunc frames for
> >> probing. When those are acked by the client, the idle time needs to be
> >> updated.
> >>
> >> To make this work (and to avoid unnecessary probing), update sta->last_rx
> >> whenever an ACK was received for a tx packet. Only do this if the flag
> >> IEEE80211_HW_REPORTS_TX_ACK_STATUS is set.
> >
> > Why that last bit? If we got an ack status, wouldn't it be OK to do
> > either way? Or are you saying drivers are lying more often than not
> > otherwise?
> I added that just in case, some drivers might not be fully reliable wrt.
> reporting the ACK status.
Ok, I'll apply it.
johannes
next prev parent reply other threads:[~2013-09-30 10:34 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-29 19:39 [PATCH 3.12 1/2] mac80211: use sta_info_get_bss() for nl80211 tx and client probing Felix Fietkau
2013-09-29 19:39 ` [PATCH 3.12 2/2] mac80211: update sta->last_rx on acked tx frames Felix Fietkau
2013-09-30 9:10 ` Johannes Berg
2013-09-30 9:46 ` Felix Fietkau
2013-09-30 10:34 ` Johannes Berg [this message]
2013-09-30 9:31 ` [PATCH 3.12 1/2] mac80211: use sta_info_get_bss() for nl80211 tx and client probing Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1380537261.14467.8.camel@jlt4.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=nbd@openwrt.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox