From: Johannes Berg <johannes@sipsolutions.net>
To: Helmut Schaa <helmut.schaa@googlemail.com>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [PATCH] nl80211: Provide per channel maximum regulatory transmit power
Date: Wed, 02 Oct 2013 10:44:30 +0200 [thread overview]
Message-ID: <1380703470.13329.1.camel@jlt4.sipsolutions.net> (raw)
In-Reply-To: <1380699789-3765-1-git-send-email-helmut.schaa@googlemail.com> (sfid-20131002_094321_138487_B88345D4)
On Wed, 2013-10-02 at 09:43 +0200, Helmut Schaa wrote:
> In some cases its not only required to know the maximum transmit power
> the hw is capable of. Instead, userspace (hostapd) might want to know
> the maximum transmit power as defined in the current regulatory domain
> (for example for 802.11d country IEs).
Why wouldn't it use (the equivalent of) "iw reg get" for that?
> + if (nla_put_u32(msg, NL80211_FREQUENCY_ATTR_MAX_REG_TX_POWER,
> + DBM_TO_MBM(chan->max_reg_power)))
> + goto nla_put_failure;
This would have to go into the "if (large)" part because otherwise older
userspace can't read the info at all since it overflows the buffer.
johannes
next prev parent reply other threads:[~2013-10-02 8:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-02 7:43 [PATCH] nl80211: Provide per channel maximum regulatory transmit power Helmut Schaa
2013-10-02 8:44 ` Johannes Berg [this message]
2013-10-02 9:04 ` Helmut Schaa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1380703470.13329.1.camel@jlt4.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=helmut.schaa@googlemail.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox