From: Johannes Berg <johannes@sipsolutions.net>
To: Chun-Yeow Yeoh <yeohchunyeow@cozybit.com>
Cc: linux-wireless@vger.kernel.org, linville@tuxdriver.com,
devel@lists.open80211s.org, distro11s@cozybit.com
Subject: Re: [PATCH v2 5/5] mac80211: process mesh channel switching using beacon
Date: Wed, 02 Oct 2013 10:47:27 +0200 [thread overview]
Message-ID: <1380703647.13329.3.camel@jlt4.sipsolutions.net> (raw)
In-Reply-To: <1380700964-844-6-git-send-email-yeohchunyeow@cozybit.com> (sfid-20131002_100302_842003_CD55053C)
On Wed, 2013-10-02 at 01:02 -0700, Chun-Yeow Yeoh wrote:
> struct cfg80211_csa_settings {
> struct cfg80211_chan_def chandef;
> @@ -695,7 +697,9 @@ struct cfg80211_csa_settings {
> struct cfg80211_beacon_data beacon_after;
> bool radar_required;
> bool block_tx;
> + u8 mode;
> u8 count;
> + u8 ttl;
> };
You certainly meant well to reuse the structs, but that doesn't make
sense. This struct is used for the cfg80211/driver (cfg80211/mac80211)
API, so adding these parameters to it makes no sense at all. It seems
you'd need a new structure that's internal to mac80211 for the function
argument.
I'd also prefer to do the refactoring in a separate patch.
johannes
prev parent reply other threads:[~2013-10-02 8:47 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-02 8:02 [PATCH v2 0/5] Add Mesh Channel Switch Support Chun-Yeow Yeoh
2013-10-02 8:02 ` [PATCH v2 1/5] mac80211: process the CSA frame for mesh accordingly Chun-Yeow Yeoh
2013-10-02 8:02 ` [PATCH v2 2/5] {nl,cfg,mac}80211: enable the triggering of CSA frame in mesh Chun-Yeow Yeoh
2013-10-02 8:02 ` [PATCH v2 3/5] mac80211: add the CSA and MCSP elements in mesh beaconing Chun-Yeow Yeoh
2013-10-02 8:02 ` [PATCH v2 4/5] {nl,cfg,mac}80211: finalizing mesh channel switching Chun-Yeow Yeoh
2013-10-02 8:50 ` Johannes Berg
2013-10-02 8:02 ` [PATCH v2 5/5] mac80211: process mesh channel switching using beacon Chun-Yeow Yeoh
2013-10-02 8:47 ` Johannes Berg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1380703647.13329.3.camel@jlt4.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=devel@lists.open80211s.org \
--cc=distro11s@cozybit.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=yeohchunyeow@cozybit.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).