From: Johannes Berg <johannes@sipsolutions.net>
To: Chun-Yeow Yeoh <yeohchunyeow@cozybit.com>
Cc: linux-wireless@vger.kernel.org, linville@tuxdriver.com,
devel@lists.open80211s.org, distro11s@cozybit.com
Subject: Re: [PATCH v2 4/5] {nl,cfg,mac}80211: finalizing mesh channel switching
Date: Wed, 02 Oct 2013 10:50:02 +0200 [thread overview]
Message-ID: <1380703802.13329.4.camel@jlt4.sipsolutions.net> (raw)
In-Reply-To: <1380700964-844-5-git-send-email-yeohchunyeow@cozybit.com> (sfid-20131002_100258_662690_85CD382C)
On Wed, 2013-10-02 at 01:02 -0700, Chun-Yeow Yeoh wrote:
> Finalizing the required procedures for channel switching completion based
> on the procedures defined in the IEEE Std 802.11-2012 section 10.9.8.4.3:
> * Add the function for updating the beacon and probe response frames
> with CSA and MCSP elements during the period of switching to the new
> channel.
> * The ifmsh->csa_settings is set to NULL and the CSA and MCSP elements
> will then be removed from the beacon or probe response frames once the
> new channel is switched to.
>
> Signed-off-by: Chun-Yeow Yeoh <yeohchunyeow@cozybit.com>
> ---
> v2: fix typo mistake, commit message and return value.
> use spinlock to protect csa_settings (Johannes Berg)
Is the spinlock really the best idea? It seems you could just use RCU
instead and avoid the extra lock? It's not exactly a hotpath, but the
paths that are assigning this should be locked already (I'd hope,
otherwise there might be more races) and the reader could be RCU.
johannes
next prev parent reply other threads:[~2013-10-02 8:50 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-02 8:02 [PATCH v2 0/5] Add Mesh Channel Switch Support Chun-Yeow Yeoh
2013-10-02 8:02 ` [PATCH v2 1/5] mac80211: process the CSA frame for mesh accordingly Chun-Yeow Yeoh
2013-10-02 8:02 ` [PATCH v2 2/5] {nl,cfg,mac}80211: enable the triggering of CSA frame in mesh Chun-Yeow Yeoh
2013-10-02 8:02 ` [PATCH v2 3/5] mac80211: add the CSA and MCSP elements in mesh beaconing Chun-Yeow Yeoh
2013-10-02 8:02 ` [PATCH v2 4/5] {nl,cfg,mac}80211: finalizing mesh channel switching Chun-Yeow Yeoh
2013-10-02 8:50 ` Johannes Berg [this message]
2013-10-02 8:02 ` [PATCH v2 5/5] mac80211: process mesh channel switching using beacon Chun-Yeow Yeoh
2013-10-02 8:47 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1380703802.13329.4.camel@jlt4.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=devel@lists.open80211s.org \
--cc=distro11s@cozybit.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=yeohchunyeow@cozybit.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).