Re: [rt2x00-users] [PATCH 1/2] rt2x00: rt2800lib: remove TXMIXER_GAIN entries from the extended EEPROM map

[Paul Menzel <paulepanter@users.sourceforge.net>]

[-- Attachment #1: Type: text/plain, Size: 1934 bytes --]

Dear Gabor,


thank you for the patch!


Am Mittwoch, den 02.10.2013, 21:41 +0200 schrieb Gabor Juhos:
> The comments are indicating the TXMIXER_GAIN_BG and
> the TXMIXED_GAIN_A entries are overlapping with the

(I think if you use »the« twice, it is just singular »entry«.)

> RSSI_BG2 and RSSI_A2 entries in the extended EEPROM
> map. This is not correct, becuase the upper byte of

bec*au*se

> the RSSI_BG2 and RSSI_A2 entries are reserved. There
> are no TX mixer gain values are stored at all in the
> extended EEPROM.
> 
> Remove the initialization of these entries from the
> extended EEPROM map to reflect this.
> 
> Signed-off-by: Gabor Juhos <juhosg@openwrt.org>
> ---
>  drivers/net/wireless/rt2x00/rt2800lib.c |    2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/net/wireless/rt2x00/rt2800lib.c b/drivers/net/wireless/rt2x00/rt2800lib.c
> index c706ddc..c979bb7 100644
> --- a/drivers/net/wireless/rt2x00/rt2800lib.c
> +++ b/drivers/net/wireless/rt2x00/rt2800lib.c
> @@ -280,10 +280,8 @@ static const unsigned int rt2800_eeprom_map_ext[EEPROM_WORD_COUNT] = {
>  	[EEPROM_RSSI_BG]		= 0x0028,
>  	[EEPROM_TXPOWER_DELTA]		= 0x0028, /* Overlaps with RSSI_BG */
>  	[EEPROM_RSSI_BG2]		= 0x0029,
> -	[EEPROM_TXMIXER_GAIN_BG]	= 0x0029, /* Overlaps with RSSI_BG2 */
>  	[EEPROM_RSSI_A]			= 0x002a,
>  	[EEPROM_RSSI_A2]		= 0x002b,
> -	[EEPROM_TXMIXER_GAIN_A]		= 0x002b, /* Overlaps with RSSI_A2 */
>  	[EEPROM_TXPOWER_BG1]		= 0x0030,
>  	[EEPROM_TXPOWER_BG2]		= 0x0037,
>  	[EEPROM_EXT_TXPOWER_BG3]	= 0x003e,

Do you know if this fixes any problems and should be backported to
stable? If any testing can be done on

        idVendor           0x148f Ralink Technology, Corp.
        idProduct          0x2870 RT2870 Wireless Adapter

please tell me.

With the fixes above,

Acked-by: Paul Menzel <paulepanter@users.sourceforge.net>


Thanks,

Paul

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 198 bytes --]