From: Johannes Berg <johannes@sipsolutions.net>
To: David Laight <David.Laight@ACULAB.COM>
Cc: djduanjiong@gmail.com,
"John W. Linville" <linville@tuxdriver.com>,
"David S. Miller" <davem@davemloft.net>,
linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
Duan Jiong <duanj.fnst@cn.fujitsu.com>
Subject: Re: [PATCH] mac80211: Use ERR_CAST inlined function instead of ERR_PTR(PTR_ERR(...))
Date: Tue, 08 Oct 2013 10:37:25 +0200 [thread overview]
Message-ID: <1381221445.13359.0.camel@jlt4.sipsolutions.net> (raw)
In-Reply-To: <AE90C24D6B3A694183C094C60CF0A2F6026B7379@saturn3.aculab.com>
On Tue, 2013-10-08 at 09:33 +0100, David Laight wrote:
> > if (IS_ERR(key))
> > - return ERR_PTR(PTR_ERR(key));
> > + return ERR_CAST(key);
>
> I suspect the old code is a deliberate attempt to indicate that it
> the error value that is being returned rather than the pointer.
I was under the impression that's what ERR_CAST means.
> Looking higher up that file there seems to be a fubar when setting
> up the TKIP key.
> It seems to put the same 6 bytes into every TID.
> (I'm sure seq_len shouldn't be ignored either.0
Both are fine.
johannes
prev parent reply other threads:[~2013-10-08 8:37 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-08 0:09 [PATCH] mac80211: Use ERR_CAST inlined function instead of ERR_PTR(PTR_ERR(...)) djduanjiong
2013-10-07 16:16 ` Johannes Berg
2013-10-08 8:33 ` David Laight
2013-10-08 8:37 ` Johannes Berg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1381221445.13359.0.camel@jlt4.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=David.Laight@ACULAB.COM \
--cc=davem@davemloft.net \
--cc=djduanjiong@gmail.com \
--cc=duanj.fnst@cn.fujitsu.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox