From: Johannes Berg <johannes@sipsolutions.net>
To: Chun-Yeow Yeoh <yeohchunyeow@cozybit.com>
Cc: linux-wireless@vger.kernel.org, linville@tuxdriver.com,
devel@lists.open80211s.org, distro11s@cozybit.com
Subject: Re: [PATCH v3 5/6] {nl,cfg,mac}80211: finalizing mesh channel switching
Date: Fri, 11 Oct 2013 15:35:11 +0200 [thread overview]
Message-ID: <1381498511.14293.17.camel@jlt4.sipsolutions.net> (raw)
In-Reply-To: <1380760429-26100-6-git-send-email-yeohchunyeow@cozybit.com> (sfid-20131003_023416_975774_DB8C026F)
On Wed, 2013-10-02 at 17:33 -0700, Chun-Yeow Yeoh wrote:
> +int ieee80211_mesh_finish_csa(struct ieee80211_sub_if_data *sdata)
> +{
> + struct ieee80211_if_mesh *ifmsh = &sdata->u.mesh;
> + struct cfg80211_csa_settings *tmp_csa_settings;
> + int ret = 0;
> +
> + /* Remove the CSA and MCSP elements from the beacon */
> + tmp_csa_settings = rcu_dereference(ifmsh->csa_settings);
> + rcu_assign_pointer(ifmsh->csa_settings, NULL);
> + kfree(tmp_csa_settings);
This looks broken without kfree_rcu() or synchronize_rcu(), if it's OK
then at least add a comment? I think it's not OK though.
johannes
next prev parent reply other threads:[~2013-10-11 13:35 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-03 0:33 [PATCH v3 0/6] Add Mesh Channel Switch Support Chun-Yeow Yeoh
2013-10-03 0:33 ` [PATCH v3 1/6] mac80211: process the CSA frame for mesh accordingly Chun-Yeow Yeoh
2013-10-03 0:33 ` [PATCH v3 2/6] {nl,cfg,mac}80211: enable the triggering of CSA frame in mesh Chun-Yeow Yeoh
2013-10-03 0:33 ` [PATCH v3 3/6] mac80211: add the CSA and MCSP elements in mesh beaconing Chun-Yeow Yeoh
2013-10-03 0:33 ` [PATCH v3 4/6] mac80211: refactor the parsing of chan switch ie Chun-Yeow Yeoh
2013-10-03 0:33 ` [PATCH v3 5/6] {nl,cfg,mac}80211: finalizing mesh channel switching Chun-Yeow Yeoh
2013-10-11 13:35 ` Johannes Berg [this message]
2013-10-11 16:44 ` Chun-Yeow Yeoh
2013-10-03 0:33 ` [PATCH v3 6/6] mac80211: process mesh channel switching using beacon Chun-Yeow Yeoh
2013-10-08 7:49 ` [PATCH v3 0/6] Add Mesh Channel Switch Support Jean-Pierre Tosoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1381498511.14293.17.camel@jlt4.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=devel@lists.open80211s.org \
--cc=distro11s@cozybit.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=yeohchunyeow@cozybit.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox