From: Johannes Berg <johannes@sipsolutions.net>
To: Mihir Shete <smihir@qti.qualcomm.com>
Cc: linux-wireless@vger.kernel.org,
Henri Bahini <hbahini@qca.qualcomm.com>,
Tushnim Bhattacharyya <tushnimb@qca.qualcomm.com>,
"Luis R. Rodriguez" <mcgrof@do-not-panic.com>
Subject: Re: [PATCH v2 1/2] cfg80211: add flags to define country IE processing rules
Date: Mon, 14 Oct 2013 10:53:33 +0200 [thread overview]
Message-ID: <1381740813.13092.9.camel@jlt4.sipsolutions.net> (raw)
In-Reply-To: <1381638697-2641-2-git-send-email-smihir@qti.qualcomm.com> (sfid-20131013_063205_048348_568E0EC6)
On Sun, 2013-10-13 at 10:01 +0530, Mihir Shete wrote:
> 802.11 cards may have different country IE parsing behavioural
> preferences and vendors may want to support these. These preferences
> were managed by the WIPHY_FLAG_CUSTOM_REGULATORY and the
> WIPHY_FLAG_STRICT_REGULATORY flags and their combination.
> Instead of using this existing notation, split out the country
> IE behavioural preferences to a new flag. This will allow
> us to add more customizations easily and make the code more
> maintainable
> regd = ath_world_regdomain(reg);
> wiphy->flags |= WIPHY_FLAG_CUSTOM_REGULATORY;
> + wiphy->country_ie_pref = NL80211_COUNTRY_IE_FOLLOW_POWER;
That seems pretty weird - maybe you should have a first patch that moves
the existing regulatory flags into some new field, and then adds the
country IE flags there? Adding a new flags field for just the country IE
seems odd and less useful for the future.
> + * @country_ie_pref: country IE processing preferences specified
> + * by enum nl80211_country_ie_pref
That implies you're exporting it to userspace - why?
> /**
> + * enum nl80211_country_ie_pref - country IE processing preferences
Why is this userspace API if it's not used anywhere as such?
johannes
next prev parent reply other threads:[~2013-10-14 8:53 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-13 4:31 [PATCH v2 0/2] cfg80211: changes to add the country IE preferences Mihir Shete
2013-10-13 4:31 ` [PATCH v2 1/2] cfg80211: add flags to define country IE processing rules Mihir Shete
2013-10-14 8:53 ` Johannes Berg [this message]
2013-10-13 4:31 ` [PATCH v2 2/2] cfg80211: add an option to disable processing country IEs Mihir Shete
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1381740813.13092.9.camel@jlt4.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=hbahini@qca.qualcomm.com \
--cc=linux-wireless@vger.kernel.org \
--cc=mcgrof@do-not-panic.com \
--cc=smihir@qti.qualcomm.com \
--cc=tushnimb@qca.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox