From: Johannes Berg <johannes@sipsolutions.net>
To: Chun-Yeow Yeoh <yeohchunyeow@cozybit.com>
Cc: linux-wireless@vger.kernel.org, linville@tuxdriver.com,
devel@lists.open80211s.org, distro11s@cozybit.com
Subject: Re: [PATCH v4 5/6] {nl,cfg,mac}80211: finalizing mesh channel switching
Date: Mon, 14 Oct 2013 16:22:09 +0200 [thread overview]
Message-ID: <1381760529.13092.17.camel@jlt4.sipsolutions.net> (raw)
In-Reply-To: <1381516190-23918-6-git-send-email-yeohchunyeow@cozybit.com> (sfid-20131011_203011_142948_D359B6FD)
On Fri, 2013-10-11 at 11:29 -0700, Chun-Yeow Yeoh wrote:
> finalizing
subject should read "finalize" or something I guess? Though it really
isn't clear to me why you split up the patches as is and didn't just put
3/5 together as "implement mesh channel switch userspace API" or so?
> struct cfg80211_csa_settings {
> + struct rcu_head rcu_head;
I don't think this belongs here, it's certainly not needed for the API.
Maybe you need a wrapper struct or so?
johannes
next prev parent reply other threads:[~2013-10-14 14:22 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-11 18:29 [PATCH v4 0/6] Add Mesh Channel Switch Support Chun-Yeow Yeoh
2013-10-11 18:29 ` [PATCH v4 1/6] mac80211: process the CSA frame for mesh accordingly Chun-Yeow Yeoh
2013-10-11 18:29 ` [PATCH v4 2/6] {nl,cfg,mac}80211: enable the triggering of CSA frame in mesh Chun-Yeow Yeoh
2013-10-14 14:14 ` Johannes Berg
2013-10-14 17:15 ` Chun-Yeow Yeoh
2013-10-11 18:29 ` [PATCH v4 3/6] mac80211: add the CSA and MCSP elements in mesh beaconing Chun-Yeow Yeoh
2013-10-14 14:16 ` Johannes Berg
2013-10-14 17:15 ` Chun-Yeow Yeoh
2013-10-14 17:45 ` Johannes Berg
2013-10-14 17:49 ` Chun-Yeow Yeoh
2013-10-14 14:18 ` Johannes Berg
2013-10-11 18:29 ` [PATCH v4 4/6] mac80211: refactor the parsing of chan switch ie Chun-Yeow Yeoh
2013-10-11 18:29 ` [PATCH v4 5/6] {nl,cfg,mac}80211: finalizing mesh channel switching Chun-Yeow Yeoh
2013-10-14 14:22 ` Johannes Berg [this message]
2013-10-14 17:17 ` Chun-Yeow Yeoh
2013-10-11 18:29 ` [PATCH v4 6/6] mac80211: process mesh channel switching using beacon Chun-Yeow Yeoh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1381760529.13092.17.camel@jlt4.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=devel@lists.open80211s.org \
--cc=distro11s@cozybit.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=yeohchunyeow@cozybit.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox