linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] mac80211: Remove check for offchannel state when waking netdev queues
@ 2013-10-15 21:16 Seth Forshee
  2013-10-17 14:28 ` Johannes Berg
  0 siblings, 1 reply; 2+ messages in thread
From: Seth Forshee @ 2013-10-15 21:16 UTC (permalink / raw)
  To: Johannes Berg; +Cc: linux-wireless

6c17b77b67587b9f9e3070fb89fe98cef3187131 ensures that a device's
mac80211 queues will remain stopped while offchannel. Since the
vif can no longer be offchannel when the queues wake it's not
necessary to check for this before waking its netdev queues.

Signed-off-by: Seth Forshee <seth.forshee@canonical.com>
---
 net/mac80211/util.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/net/mac80211/util.c b/net/mac80211/util.c
index e1b34a1..561af30 100644
--- a/net/mac80211/util.c
+++ b/net/mac80211/util.c
@@ -300,9 +300,6 @@ void ieee80211_propagate_queue_wake(struct ieee80211_local *local, int queue)
 		if (!sdata->dev)
 			continue;
 
-		if (test_bit(SDATA_STATE_OFFCHANNEL, &sdata->state))
-			continue;
-
 		if (sdata->vif.cab_queue != IEEE80211_INVAL_HW_QUEUE &&
 		    local->queue_stop_reasons[sdata->vif.cab_queue] != 0)
 			continue;
-- 
1.8.3.2


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] mac80211: Remove check for offchannel state when waking netdev queues
  2013-10-15 21:16 [PATCH] mac80211: Remove check for offchannel state when waking netdev queues Seth Forshee
@ 2013-10-17 14:28 ` Johannes Berg
  0 siblings, 0 replies; 2+ messages in thread
From: Johannes Berg @ 2013-10-17 14:28 UTC (permalink / raw)
  To: Seth Forshee; +Cc: linux-wireless

On Tue, 2013-10-15 at 16:16 -0500, Seth Forshee wrote:
> 6c17b77b67587b9f9e3070fb89fe98cef3187131 ensures that a device's
> mac80211 queues will remain stopped while offchannel. Since the
> vif can no longer be offchannel when the queues wake it's not
> necessary to check for this before waking its netdev queues.

Applied.

johannes


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2013-10-17 14:28 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-10-15 21:16 [PATCH] mac80211: Remove check for offchannel state when waking netdev queues Seth Forshee
2013-10-17 14:28 ` Johannes Berg

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).