public inbox for linux-wireless@vger.kernel.org
 help / color / mirror / Atom feed
From: Johannes Berg <johannes@sipsolutions.net>
To: Antonio Quartulli <antonio@meshcoding.com>
Cc: linux-wireless@vger.kernel.org,
	Antonio Quartulli <antonio@open-mesh.com>
Subject: Re: [PATCH 1/2] cfg80211: on ibss_joined use the channel to get the proper bss object
Date: Thu, 17 Oct 2013 16:35:58 +0200	[thread overview]
Message-ID: <1382020558.14410.11.camel@jlt4.sipsolutions.net> (raw)
In-Reply-To: <1381790282-1146-1-git-send-email-antonio@meshcoding.com>

On Tue, 2013-10-15 at 00:38 +0200, Antonio Quartulli wrote:
> From: Antonio Quartulli <antonio@open-mesh.com>
> 
> It may be the case that the same IBSS (same bssid and essid)
> exists on two different channels (i.e. two IBSSes created
> with different but fixed freq) and therefore the latter must
> be also used to distinguish them.
> 
> Fix wdev->current_bss assignment by passing the channel to
> cfg80211_get_bss() on ibss_joined.
> This ensures that cfg80211_get_bss() picks up the proper bss
> object.

This makes no sense, wdev->channel should always be NULL (unless the
same wdev was in AP or mesh mode first and that somehow leaked out?)

johannes


      parent reply	other threads:[~2013-10-17 14:36 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-14 22:38 [PATCH 1/2] cfg80211: on ibss_joined use the channel to get the proper bss object Antonio Quartulli
2013-10-14 22:38 ` [PATCH 2/2] mac80211: store the channel in wdev upon ibss_join Antonio Quartulli
2013-10-17 14:36   ` Johannes Berg
2013-10-17 14:48     ` Antonio Quartulli
2013-10-17 14:51       ` Johannes Berg
2013-10-17 14:57         ` Antonio Quartulli
2013-10-17 14:35 ` Johannes Berg [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1382020558.14410.11.camel@jlt4.sipsolutions.net \
    --to=johannes@sipsolutions.net \
    --cc=antonio@meshcoding.com \
    --cc=antonio@open-mesh.com \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox