linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Luis R. Rodriguez" <mcgrof@do-not-panic.com>
To: linville@tuxdriver.com, johannes@sipsolutions.net
Cc: linux-wireless@vger.kernel.org, janusz.dziedzic@tieto.com,
	smihir@qti.qualcomm.com, tushnimb@qca.qualcomm.com,
	"Luis R. Rodriguez" <mcgrof@do-not-panic.com>
Subject: [PATCH] cfg80211: clarify DFS / CAC case for the new NO-IR flag
Date: Mon, 21 Oct 2013 19:27:20 +0200	[thread overview]
Message-ID: <1382376440-25838-1-git-send-email-mcgrof@do-not-panic.com> (raw)

Now that the no-ibss and passive-scan flags are bundled
together its a lot easier to deal with the case of when
we support DFS. If DFS is supported on the wiphy and if
the Channel availability check (CAC) has been cleared on
the channel (dfs_state is NL80211_DFS_AVAILABLE) we can
ignore the no-ir flag.

This simplifies the paranoid requirement of bundling
together DFS and NO-IR cases by placing onus on the
DFS implementation. If code paths also want to reuse
knowledge from DFS state machines they must also ensure
that they always look at and monitor the dfs_state.

Cc: Janusz Dziedzic <janusz.dziedzic@tieto.com>
Cc: smihir@qti.qualcomm.com
Cc: tushnimb@qca.qualcomm.com
Signed-off-by: Luis R. Rodriguez <mcgrof@do-not-panic.com>
---

This depends on the 2 series I posted just before, the ath
driver updates and the wlan driver merge of consolidating flags.

 include/net/cfg80211.h | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/include/net/cfg80211.h b/include/net/cfg80211.h
index 54cc9f8..b5cee04 100644
--- a/include/net/cfg80211.h
+++ b/include/net/cfg80211.h
@@ -92,7 +92,11 @@ enum ieee80211_band {
  *
  * @IEEE80211_CHAN_DISABLED: This channel is disabled.
  * @IEEE80211_CHAN_NO_IR: do not initiate radiation, this includes
- * 	sending probe requests or beaconing.
+ * 	sending probe requests or beaconing. Channels that have
+ * 	%IEEE80211_CHAN_RADAR enabled can ignore this flag if
+ * 	and only if the Channel availability check (CAC) has
+ * 	been cleared on it, that is when the channel's dfs_state
+ * 	is %NL80211_DFS_AVAILABLE.
  * @IEEE80211_CHAN_RADAR: Radar detection is required on this channel.
  * @IEEE80211_CHAN_NO_HT40PLUS: extension channel above this channel
  * 	is not permitted.
-- 
1.8.4.rc3


             reply	other threads:[~2013-10-21 17:27 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-21 17:27 Luis R. Rodriguez [this message]
2013-10-28 14:43 ` [PATCH] cfg80211: clarify DFS / CAC case for the new NO-IR flag Johannes Berg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1382376440-25838-1-git-send-email-mcgrof@do-not-panic.com \
    --to=mcgrof@do-not-panic.com \
    --cc=janusz.dziedzic@tieto.com \
    --cc=johannes@sipsolutions.net \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    --cc=smihir@qti.qualcomm.com \
    --cc=tushnimb@qca.qualcomm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).