From: Joe Perches <joe@perches.com>
To: Georgiana Rodica Chelu <georgiana.chelu93@gmail.com>
Cc: opw-kernel@googlegroups.com, linux-wireless@vger.kernel.org
Subject: Re: [Patch v2 1/3] net: wireless: replace printk with netdev_warn in adm8211.c
Date: Thu, 24 Oct 2013 15:46:33 -0700 [thread overview]
Message-ID: <1382654793.22433.91.camel@joe-AO722> (raw)
In-Reply-To: <20131024213026.GA3569@fireworks>
On Fri, 2013-10-25 at 00:30 +0300, Georgiana Rodica Chelu wrote:
> WARNING: Prefer netdev_warn(netdev, ... then dev_warn(dev, ... then pr_warn(...
> to printk(KERN_WARNING ...
Hi Georgiana.
Please compile and test your patches before submitting them.
> diff --git a/drivers/net/wireless/adm8211.c b/drivers/net/wireless/adm8211.c
> @@ -151,8 +151,9 @@ static int adm8211_read_eeprom(struct ieee80211_hw *dev)
> else
> priv->rf_type = ADM8211_TYPE_AIROHA;
>
> - printk(KERN_WARNING "%s (adm8211): Unknown RFtype %d\n",
> - pci_name(priv->pdev), (cr49 >> 3) & 0x7);
> + netdev_warn(priv->pdev, "(adm8211): Unknown RFtype %d\n",
> + pci_name(priv->pdev), (cr49 >> 3) & 0x7);
> +
> }
>
> priv->bbp_type = cr49 & 0x7;
netdev_warn 1st arg is a struct net_device *
priv->pdev is a struct pci_dev *
prev parent reply other threads:[~2013-10-24 22:46 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-24 21:30 [Patch v2 1/3] net: wireless: replace printk with netdev_warn in adm8211.c Georgiana Rodica Chelu
2013-10-24 22:46 ` Joe Perches [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1382654793.22433.91.camel@joe-AO722 \
--to=joe@perches.com \
--cc=georgiana.chelu93@gmail.com \
--cc=linux-wireless@vger.kernel.org \
--cc=opw-kernel@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox