From: Johannes Berg <johannes@sipsolutions.net>
To: Stanislaw Gruszka <sgruszka@redhat.com>
Cc: linux-wireless@vger.kernel.org, Dietmar Rudolph <dietmar@crlf.de>
Subject: Re: [PATCH] iwl3945: do not print RFKILL message
Date: Fri, 25 Oct 2013 13:17:59 +0200 [thread overview]
Message-ID: <1382699879.12755.0.camel@jlt4.sipsolutions.net> (raw)
In-Reply-To: <20131025103751.GB16384@redhat.com> (sfid-20131025_124130_652554_7E7D6F5E)
On Fri, 2013-10-25 at 12:37 +0200, Stanislaw Gruszka wrote:
> We can mess logs if user space try to open device again and again if
> RFKILL switch is on. Do not print message and return ERFKILL error
> instead to indicate where the problem is.
Are you maybe not calling wiphy_rfkill_set_hw_state() in the right
places?
johannes
next prev parent reply other threads:[~2013-10-25 11:18 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-25 10:37 [PATCH] iwl3945: do not print RFKILL message Stanislaw Gruszka
2013-10-25 11:17 ` Johannes Berg [this message]
2013-10-30 8:34 ` Stanislaw Gruszka
2013-10-30 8:51 ` Dietmar Rudolph
2013-10-30 13:34 ` Pedro Francisco
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1382699879.12755.0.camel@jlt4.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=dietmar@crlf.de \
--cc=linux-wireless@vger.kernel.org \
--cc=sgruszka@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).