* [PATCH -next] libertas: fix error return code in if_cs_probe()
@ 2013-10-30 5:22 Wei Yongjun
2013-10-30 14:42 ` Dan Williams
0 siblings, 1 reply; 2+ messages in thread
From: Wei Yongjun @ 2013-10-30 5:22 UTC (permalink / raw)
To: linville, hsweeten, gregkh, dcbw
Cc: yongjun_wei, libertas-dev, linux-wireless
From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Fix to return -ENODEV in the unknown model error handling
case instead of 0, as done elsewhere in this function.
Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
---
drivers/net/wireless/libertas/if_cs.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/wireless/libertas/if_cs.c b/drivers/net/wireless/libertas/if_cs.c
index ef8c98e..f499efc 100644
--- a/drivers/net/wireless/libertas/if_cs.c
+++ b/drivers/net/wireless/libertas/if_cs.c
@@ -902,6 +902,7 @@ static int if_cs_probe(struct pcmcia_device *p_dev)
if (card->model == MODEL_UNKNOWN) {
pr_err("unsupported manf_id 0x%04x / card_id 0x%04x\n",
p_dev->manf_id, p_dev->card_id);
+ ret = -ENODEV;
goto out2;
}
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH -next] libertas: fix error return code in if_cs_probe()
2013-10-30 5:22 [PATCH -next] libertas: fix error return code in if_cs_probe() Wei Yongjun
@ 2013-10-30 14:42 ` Dan Williams
0 siblings, 0 replies; 2+ messages in thread
From: Dan Williams @ 2013-10-30 14:42 UTC (permalink / raw)
To: Wei Yongjun
Cc: linville, hsweeten, gregkh, yongjun_wei, linux-wireless,
libertas-dev
On Wed, 2013-10-30 at 13:22 +0800, Wei Yongjun wrote:
> From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
>
> Fix to return -ENODEV in the unknown model error handling
> case instead of 0, as done elsewhere in this function.
>
> Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Acked-by: Dan Williams <dcbw@redhat.com>
> ---
> drivers/net/wireless/libertas/if_cs.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/wireless/libertas/if_cs.c b/drivers/net/wireless/libertas/if_cs.c
> index ef8c98e..f499efc 100644
> --- a/drivers/net/wireless/libertas/if_cs.c
> +++ b/drivers/net/wireless/libertas/if_cs.c
> @@ -902,6 +902,7 @@ static int if_cs_probe(struct pcmcia_device *p_dev)
> if (card->model == MODEL_UNKNOWN) {
> pr_err("unsupported manf_id 0x%04x / card_id 0x%04x\n",
> p_dev->manf_id, p_dev->card_id);
> + ret = -ENODEV;
> goto out2;
> }
>
>
>
> _______________________________________________
> libertas-dev mailing list
> libertas-dev@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/libertas-dev
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-10-30 14:42 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-10-30 5:22 [PATCH -next] libertas: fix error return code in if_cs_probe() Wei Yongjun
2013-10-30 14:42 ` Dan Williams
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).