From: Johannes Berg <johannes@sipsolutions.net>
To: Jouni Malinen <j@w1.fi>
Cc: "John W. Linville" <linville@tuxdriver.com>,
linux-wireless@vger.kernel.org
Subject: Re: [PATCH] mac80211_hwsim: Fix radiotap header for ACK frames
Date: Mon, 04 Nov 2013 09:25:09 +0100 [thread overview]
Message-ID: <1383553509.14295.0.camel@jlt4.sipsolutions.net> (raw)
In-Reply-To: <20131102135736.GA14411@w1.fi>
On Sat, 2013-11-02 at 15:57 +0200, Jouni Malinen wrote:
> The earlier addition of rt_tsft to struct hwsim_radiotap_hdr updated
> only mac80211_hwsim_monitor_tx() to fill in the new field.
> mac80211_hwsim_monitor_ack() did not set the rt_tsft field and as such,
> leaked eight bytes of kernel memory to user space. In addition, the
> resulting radiotap header is invalid since the field offsets do not
> match. Fix these issues by defining a separate radiotap header structure
> for the ACK frame case which does not use all the fields.
Applied, thanks.
johannes
prev parent reply other threads:[~2013-11-04 9:08 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-02 13:57 [PATCH] mac80211_hwsim: Fix radiotap header for ACK frames Jouni Malinen
2013-11-04 8:25 ` Johannes Berg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1383553509.14295.0.camel@jlt4.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=j@w1.fi \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).