public inbox for linux-wireless@vger.kernel.org
 help / color / mirror / Atom feed
From: Johannes Berg <johannes@sipsolutions.net>
To: Luciano Coelho <luciano.coelho@intel.com>
Cc: linux-wireless@vger.kernel.org, sw@simonwunderlich.de
Subject: Re: [RFC v2 2/2] mac80211: only set CSA beacon when at least one beacon must be transmitted
Date: Wed, 06 Nov 2013 11:51:41 +0100	[thread overview]
Message-ID: <1383735101.14307.25.camel@jlt4.sipsolutions.net> (raw)
In-Reply-To: <1383684854-21663-2-git-send-email-luciano.coelho@intel.com>

On Tue, 2013-11-05 at 22:54 +0200, Luciano Coelho wrote:
> With a CSA count of 0, we won't transmit any CSA beacons, because the
> switch will happen before the next TBTT.  To avoid extra work and
> potential confusion in the drivers, complete the CSA immediately,
> instead of waiting for the driver to call ieee80211_csa_finish().

Does it make sense to go to the workqueue rather than do it inline?

Maybe we should just reject this? I'm a bit worried that this might
confuse drivers that expect a certain order of calls?

johannes


  reply	other threads:[~2013-11-06 10:51 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-05 20:54 [RFC v2 1/2] mac80211: don't transmit beacon with CSA count 0 Luciano Coelho
2013-11-05 20:54 ` [RFC v2 2/2] mac80211: only set CSA beacon when at least one beacon must be transmitted Luciano Coelho
2013-11-06 10:51   ` Johannes Berg [this message]
2013-11-06 11:28     ` Coelho, Luciano
2013-11-06 11:31       ` Johannes Berg
2013-11-06 11:52         ` Coelho, Luciano
2013-11-06 12:06           ` Johannes Berg
2013-11-06 11:47   ` Simon Wunderlich
2013-11-06 12:03     ` Coelho, Luciano
2013-11-06 12:06       ` Johannes Berg
2013-11-06 12:22         ` Coelho, Luciano
2013-11-06 12:36           ` Johannes Berg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1383735101.14307.25.camel@jlt4.sipsolutions.net \
    --to=johannes@sipsolutions.net \
    --cc=linux-wireless@vger.kernel.org \
    --cc=luciano.coelho@intel.com \
    --cc=sw@simonwunderlich.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox