From: Johannes Berg <johannes@sipsolutions.net>
To: linux-wireless@vger.kernel.org
Cc: Eliad Peller <eliadx.peller@intel.com>
Subject: Re: [PATCH] mac80211: fix scheduled scan rtnl deadlock
Date: Wed, 06 Nov 2013 11:58:07 +0100 [thread overview]
Message-ID: <1383735487.14307.29.camel@jlt4.sipsolutions.net> (raw)
In-Reply-To: <1383730993-18259-1-git-send-email-johannes@sipsolutions.net> (sfid-20131106_104320_884172_2DC34946)
On Wed, 2013-11-06 at 10:43 +0100, Johannes Berg wrote:
> From: Johannes Berg <johannes.berg@intel.com>
>
> When changing cfg80211 to use RTNL locking, this caused a
> deadlock in mac80211 as it calls cfg80211_sched_scan_stopped()
> from a work item that's on a workqueue that is flushed with
> the RTNL held.
>
> Fix this by simply using schedule_work(), the work only needs
> to finish running before the wiphy is unregistered, no other
> synchronisation (e.g. with suspend) is really required since
> for suspend userspace is already blocked anyway when we flush
> the workqueue so will only pick up the event after resume.
Applied.
johannes
prev parent reply other threads:[~2013-11-06 10:58 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-06 9:43 [PATCH] mac80211: fix scheduled scan rtnl deadlock Johannes Berg
2013-11-06 10:58 ` Johannes Berg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1383735487.14307.29.camel@jlt4.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=eliadx.peller@intel.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).