public inbox for linux-wireless@vger.kernel.org
 help / color / mirror / Atom feed
From: Johannes Berg <johannes@sipsolutions.net>
To: "Coelho, Luciano" <luciano.coelho@intel.com>
Cc: "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
	"sw@simonwunderlich.de" <sw@simonwunderlich.de>
Subject: Re: [RFC v2 2/2] mac80211: only set CSA beacon when at least one beacon must be transmitted
Date: Wed, 06 Nov 2013 13:06:00 +0100	[thread overview]
Message-ID: <1383739560.14307.40.camel@jlt4.sipsolutions.net> (raw)
In-Reply-To: <1383738685.4256.50.camel@porter.coelho.fi>

On Wed, 2013-11-06 at 11:52 +0000, Coelho, Luciano wrote:

> Right.  I actually added this to the documentation, but I accidentally
> sent it as part of patch 1/2:
> 
> > +++ b/include/net/mac80211.h
> > @@ -2676,11 +2676,13 @@ enum ieee80211_roc_type {
> >   * @channel_switch_beacon: Starts a channel switch to a new channel.
> [...]
> > + *     If the CSA count starts as zero or 1, this function will not be called,
> > + *     since there won't be any time to beacon before the switch anyway.
> 
> This change should be in patch 2/2 (actually these two patches should
> probably be squashed, I just kept them separate so that reviewing my v2
> would be easier).
> 
> I can elaborate more in the documentation if you think it's necessary.

Ah, ok, I guess that's fine.

johannes


  reply	other threads:[~2013-11-06 12:06 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-05 20:54 [RFC v2 1/2] mac80211: don't transmit beacon with CSA count 0 Luciano Coelho
2013-11-05 20:54 ` [RFC v2 2/2] mac80211: only set CSA beacon when at least one beacon must be transmitted Luciano Coelho
2013-11-06 10:51   ` Johannes Berg
2013-11-06 11:28     ` Coelho, Luciano
2013-11-06 11:31       ` Johannes Berg
2013-11-06 11:52         ` Coelho, Luciano
2013-11-06 12:06           ` Johannes Berg [this message]
2013-11-06 11:47   ` Simon Wunderlich
2013-11-06 12:03     ` Coelho, Luciano
2013-11-06 12:06       ` Johannes Berg
2013-11-06 12:22         ` Coelho, Luciano
2013-11-06 12:36           ` Johannes Berg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1383739560.14307.40.camel@jlt4.sipsolutions.net \
    --to=johannes@sipsolutions.net \
    --cc=linux-wireless@vger.kernel.org \
    --cc=luciano.coelho@intel.com \
    --cc=sw@simonwunderlich.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox