From: Joe Perches <joe@perches.com>
To: Arend van Spriel <arend@broadcom.com>
Cc: "John W. Linville" <linville@tuxdriver.com>,
linux-wireless@vger.kernel.org
Subject: Re: [PATCH 6/7] brcmfmac: reduce logging noise accessing SDIO SleepCSR register
Date: Wed, 06 Nov 2013 15:53:33 -0800 [thread overview]
Message-ID: <1383782013.7940.41.camel@joe-AO722> (raw)
In-Reply-To: <1383775642-647-7-git-send-email-arend@broadcom.com>
On Wed, 2013-11-06 at 23:07 +0100, Arend van Spriel wrote:
> The SleepCSR register is accessed to wakeup the device from the
> host side. Depending on the state of the device this may take
> multiple attempts. The failed attempt are not real failures so
> reduce the log level specifically for this register. The calling
> function will scream when the multiple attempts all failed.
[]
> diff --git a/drivers/net/wireless/brcm80211/brcmfmac/bcmsdh_sdmmc.c b/drivers/net/wireless/brcm80211/brcmfmac/bcmsdh_sdmmc.c
[]
> + if (err_ret) {
Maybe better as:
if (err_ret && net_ratelimit()) { ?
> + /*
> + * SleepCSR register access can fail when
> + * waking up the device so reduce this noise
> + * in the logs.
> + */
> + if (regaddr != SBSDIO_FUNC1_SLEEPCSR)
> + brcmf_err("Failed to %s byte F%d:@0x%05x=%02x, Err: %d\n",
> + rw ? "write" : "read", func, regaddr, *byte,
> + err_ret);
> + else
> + brcmf_dbg(SDIO, "Failed to %s byte F%d:@0x%05x=%02x, Err: %d\n",
> + rw ? "write" : "read", func, regaddr, *byte,
> + err_ret);
> + }
next prev parent reply other threads:[~2013-11-06 23:53 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-06 22:07 [PATCH 0/7] brcm80211: cleanup fixes and out-of-order fix Arend van Spriel
2013-11-06 22:07 ` [PATCH 1/7] brcmfmac: Update fwsignal to fix out of order tx Arend van Spriel
2013-11-06 22:07 ` [PATCH 2/7] brcmfmac: add separate function for passing bus tx overhead Arend van Spriel
2013-11-06 22:07 ` [PATCH 3/7] brcmfmac: replace dongle command list with .preinit() callback Arend van Spriel
2013-11-06 22:07 ` [PATCH 4/7] brcmfmac: start netif queues only when setup is completed successful Arend van Spriel
2013-11-06 22:07 ` [PATCH 5/7] brcmfmac: remove empty brcmf_proto_stop Arend van Spriel
2013-11-06 22:07 ` [PATCH 6/7] brcmfmac: reduce logging noise accessing SDIO SleepCSR register Arend van Spriel
2013-11-06 23:53 ` Joe Perches [this message]
2013-11-07 9:31 ` Arend van Spriel
2013-11-06 22:07 ` [PATCH 7/7] brcmsmac: select CONFIG_BCMA when possible Arend van Spriel
2013-11-20 9:36 ` [PATCH 0/7] brcm80211: cleanup fixes and out-of-order fix Arend van Spriel
2013-11-20 16:29 ` John W. Linville
2013-11-20 17:30 ` Arend van Spriel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1383782013.7940.41.camel@joe-AO722 \
--to=joe@perches.com \
--cc=arend@broadcom.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).