From: Johannes Berg <johannes@sipsolutions.net>
To: Luciano Coelho <luciano.coelho@intel.com>
Cc: linux-wireless@vger.kernel.org, sw@simonwunderlich.de
Subject: Re: [RFC v3 1/4] mac80211: don't transmit beacon with CSA count 0
Date: Mon, 11 Nov 2013 14:59:20 +0100 [thread overview]
Message-ID: <1384178360.14334.18.camel@jlt4.sipsolutions.net> (raw)
In-Reply-To: <1383921579-22373-1-git-send-email-luciano.coelho@intel.com>
On Fri, 2013-11-08 at 16:39 +0200, Luciano Coelho wrote:
> A beacon should never have a Channel Switch Announcement information
> element with a count of 0, because a count of 1 means switch just
> before the next beacon. So, if a count of 0 was valid in a beacon, it
> would have been transmitted in the next channel already, which is
> useless. A CSA count equal to zero is only meaningful in action
> frames or probe_responses.
>
> Fix the ieee80211_csa_is_complete() and ieee80211_update_csa()
> functions accordingly.
These seem fine to me - maybe we should have some CSA tests in Jouni's
hwsim test scripts, for the various cases? :)
johannes
next prev parent reply other threads:[~2013-11-11 13:59 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-08 14:39 [RFC v3 1/4] mac80211: don't transmit beacon with CSA count 0 Luciano Coelho
2013-11-08 14:39 ` [RFC v3 2/4] mac80211: refactor ieee80211_ibss_process_chanswitch() Luciano Coelho
2013-11-08 14:39 ` [RFC v3 3/4] mac80211: align ieee80211_ibss_csa_beacon() with ieee80211_csa_beacon() Luciano Coelho
2013-11-08 14:39 ` [RFC v3 4/4] mac80211: only set CSA beacon when at least one beacon must be transmitted Luciano Coelho
2013-11-08 14:42 ` [RFC v3 1/4] mac80211: don't transmit beacon with CSA count 0 Luca Coelho
2013-11-11 13:59 ` Johannes Berg [this message]
2013-11-12 8:09 ` Coelho, Luciano
2013-11-11 14:57 ` Simon Wunderlich
2013-11-12 8:22 ` Coelho, Luciano
2013-11-12 11:04 ` Simon Wunderlich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1384178360.14334.18.camel@jlt4.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=luciano.coelho@intel.com \
--cc=sw@simonwunderlich.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).