From: Johannes Berg <johannes@sipsolutions.net>
To: Chun-Yeow Yeoh <yeohchunyeow@gmail.com>
Cc: linux-wireless@vger.kernel.org, linville@tuxdriver.com,
devel@lists.open80211s.org, distro11s@cozybit.com
Subject: Re: [PATCH v4] mac80211: fix the mesh channel switch support
Date: Mon, 11 Nov 2013 15:06:18 +0100 [thread overview]
Message-ID: <1384178778.14334.21.camel@jlt4.sipsolutions.net> (raw)
In-Reply-To: <1383894583-3454-1-git-send-email-yeohchunyeow@gmail.com> (sfid-20131108_081202_001431_43D4F2F5)
On Fri, 2013-11-08 at 15:09 +0800, Chun-Yeow Yeoh wrote:
> Mesh STA receiving the mesh CSA action frame is not able to trigger
> the mesh channel switch due to the incorrect handling and comparison
> of mesh channel switch parameters element (MCSP)'s TTL. Make sure
> the MCSP's TTL is updated accordingly before calling the
> ieee80211_mesh_process_chnswitch. Also, we update the beacon before
> forwarding the CSA action frame, so MCSP's precedence value and
> initiator flag need to be updated prior to this.
I guess I'll apply this.
> pre_value = cpu_to_le16(ifmsh->pre_value);
> memcpy(pos, &pre_value, 2); /* Precedence Value */
> pos += 2;
However, it seems to me that you should be using put_unaligned_le16() or
so in places like this - maybe clean them all up?
johannes
prev parent reply other threads:[~2013-11-11 14:06 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-08 7:09 [PATCH v4] mac80211: fix the mesh channel switch support Chun-Yeow Yeoh
2013-11-11 14:06 ` Johannes Berg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1384178778.14334.21.camel@jlt4.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=devel@lists.open80211s.org \
--cc=distro11s@cozybit.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=yeohchunyeow@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).