linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Sujith Manoharan <sujith@msujith.org>
To: John Linville <linville@tuxdriver.com>
Cc: linux-wireless@vger.kernel.org
Subject: [PATCH 5/5] ath9k: Fix TX IQ calibration for SoC chips
Date: Sun, 17 Nov 2013 10:40:16 +0530	[thread overview]
Message-ID: <1384665016-12022-5-git-send-email-sujith@msujith.org> (raw)
In-Reply-To: <1384665016-12022-1-git-send-email-sujith@msujith.org>

From: Sujith Manoharan <c_manoha@qca.qualcomm.com>

Since calibration data reuse is not enabled in
SoC chips, simplify the IQ calibration code.

Signed-off-by: Sujith Manoharan <c_manoha@qca.qualcomm.com>
---
 drivers/net/wireless/ath/ath9k/ar9003_calib.c | 20 ++++++++------------
 1 file changed, 8 insertions(+), 12 deletions(-)

diff --git a/drivers/net/wireless/ath/ath9k/ar9003_calib.c b/drivers/net/wireless/ath/ath9k/ar9003_calib.c
index 58eacf1..a18c3dd 100644
--- a/drivers/net/wireless/ath/ath9k/ar9003_calib.c
+++ b/drivers/net/wireless/ath/ath9k/ar9003_calib.c
@@ -1255,22 +1255,19 @@ static bool ar9003_hw_init_cal_soc(struct ath_hw *ah,
 
 	/*
 	 * For AR9485 or later chips, TxIQ cal runs as part of
-	 * AGC calibration
+	 * AGC calibration. Specifically, AR9550 in SoC chips.
 	 */
 	if (ah->enabled_cals & TX_IQ_ON_AGC_CAL) {
-		if (caldata && !test_bit(TXIQCAL_DONE, &caldata->cal_flags))
-			REG_SET_BIT(ah, AR_PHY_TX_IQCAL_CONTROL_0,
-				    AR_PHY_TX_IQCAL_CONTROL_0_ENABLE_TXIQ_CAL);
-		else
-			REG_CLR_BIT(ah, AR_PHY_TX_IQCAL_CONTROL_0,
-				    AR_PHY_TX_IQCAL_CONTROL_0_ENABLE_TXIQ_CAL);
-		txiqcal_done = run_agc_cal = true;
-	} else if (caldata && !test_bit(TXIQCAL_DONE, &caldata->cal_flags)) {
+		txiqcal_done = true;
 		run_agc_cal = true;
+	} else {
 		sep_iq_cal = true;
+		run_agc_cal = true;
 	}
 
-skip_tx_iqcal:
+	/*
+	 * In the SoC family, this will run for AR9300, AR9331 and AR9340.
+	 */
 	if (sep_iq_cal) {
 		txiqcal_done = ar9003_hw_tx_iq_cal_run(ah);
 		REG_WRITE(ah, AR_PHY_ACTIVE, AR_PHY_ACTIVE_DIS);
@@ -1278,6 +1275,7 @@ skip_tx_iqcal:
 		REG_WRITE(ah, AR_PHY_ACTIVE, AR_PHY_ACTIVE_EN);
 	}
 
+skip_tx_iqcal:
 	if (run_agc_cal || !(ah->ah_flags & AH_FASTCC)) {
 		/* Calibrate the AGC */
 		REG_WRITE(ah, AR_PHY_AGC_CONTROL,
@@ -1299,8 +1297,6 @@ skip_tx_iqcal:
 
 	if (txiqcal_done)
 		ar9003_hw_tx_iq_cal_post_proc(ah, is_reusable);
-	else if (caldata && test_bit(TXIQCAL_DONE, &caldata->cal_flags))
-		ar9003_hw_tx_iq_cal_reload(ah);
 
 	/* Revert chainmask to runtime parameters */
 	ar9003_hw_set_chain_masks(ah, ah->rxchainmask, ah->txchainmask);
-- 
1.8.4.2


  parent reply	other threads:[~2013-11-17  5:14 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-17  5:10 [PATCH 1/5] ath9k: Separate routines for PCOEM and SoC calibration Sujith Manoharan
2013-11-17  5:10 ` [PATCH 2/5] ath9k: Remove RTT/MCI code from " Sujith Manoharan
2013-11-17  5:10 ` [PATCH 3/5] ath9k: Remove unnecessary check Sujith Manoharan
2013-11-17  5:10 ` [PATCH 4/5] ath9k: Fix Carrier Leak calibration for SoC chips Sujith Manoharan
2013-11-17  5:10 ` Sujith Manoharan [this message]
2014-01-09 12:17   ` [PATCH 5/5] ath9k: Fix TX IQ " Wojciech Dubowik
2014-01-09 13:10     ` Sujith Manoharan
2014-01-09 13:35       ` Wojciech Dubowik
2014-01-09 13:52         ` Sujith Manoharan
2014-01-09 13:59           ` Wojciech Dubowik
2014-01-13 14:34             ` Wojciech Dubowik
2014-01-13 15:07               ` Sujith Manoharan
     [not found]                 ` <52D402C3.3070606@neratec.com>
     [not found]                   ` <21204.1991.201080.986559@gargle.gargle.HOWL>
2014-01-13 15:42                     ` Sujith Manoharan
2014-01-13 16:06                       ` Sujith Manoharan
2014-01-15  7:54                         ` Wojciech Dubowik
2014-01-15  8:15                           ` Sujith Manoharan
2014-01-15  8:30                             ` Wojciech Dubowik
2014-01-16 11:06                               ` Sujith Manoharan
2014-01-16 11:19                                 ` Sujith Manoharan
2014-01-16 11:44                                   ` Wojciech Dubowik
2014-01-16 21:36                                     ` Sujith Manoharan
2014-01-17  7:30                                       ` Wojciech Dubowik
2014-01-20  3:33                                         ` Sujith Manoharan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1384665016-12022-5-git-send-email-sujith@msujith.org \
    --to=sujith@msujith.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).