public inbox for linux-wireless@vger.kernel.org
 help / color / mirror / Atom feed
From: Johannes Berg <johannes@sipsolutions.net>
To: Krishna Chaitanya <chaitanya.mgit@gmail.com>
Cc: linux-wireless <linux-wireless@vger.kernel.org>
Subject: Re: [Query] Update mac80211 BSS info from cfg8011_bss_inform_frame when hw_scan is enabled
Date: Mon, 18 Nov 2013 14:01:06 +0100	[thread overview]
Message-ID: <1384779666.17916.11.camel@jlt4.sipsolutions.net> (raw)
In-Reply-To: <CABPxzY+XHXCFpKxU1NPZzb4eXP7x8i0-89eE+7uxWqGKnNsePw@mail.gmail.com> (sfid-20131117_141416_294368_7F94FDA4)

On Sun, 2013-11-17 at 18:43 +0530, Krishna Chaitanya wrote:

> > You're not supposed to even call cfg80211_bss_inform_frame() from a
> > mac80211-based driver. Just report the RX frame properly.

> Ours is a partial Full MAC driver which still uses mac80211 but mostly with
> offloads to HW.
> 
> With mac80211 + hw_scan if we just report the RX frames, then we are just
> eliminating the SCAN SM from mac80211, is this just to reduce the host
> cycles? (apart from speeding up the channel switch)

When you post the driver for upstream we can talk about it. I have no
interest in it otherwise - but

 (a) you can't call cfg80211 from the driver and then have cfg80211 call
mac80211
     - that's a gross layering violation
 (b) if you're offloading much, you're probably not using a lot of
mac80211 and
     should come with a proposal to refactor the code

johannes


  reply	other threads:[~2013-11-18 13:01 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-15 19:49 [Query] Update mac80211 BSS info from cfg8011_bss_inform_frame when hw_scan is enabled Krishna Chaitanya
2013-11-17  9:16 ` Johannes Berg
2013-11-17 13:13   ` Krishna Chaitanya
2013-11-18 13:01     ` Johannes Berg [this message]
2013-11-18 16:22       ` Krishna Chaitanya

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1384779666.17916.11.camel@jlt4.sipsolutions.net \
    --to=johannes@sipsolutions.net \
    --cc=chaitanya.mgit@gmail.com \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox