linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Emmanuel Grumbach <egrumbach@gmail.com>
To: johannes@sipsolutions.net
Cc: linux-wireless@vger.kernel.org, Avri Altman <avri.altman@intel.com>
Subject: [PATCH 4/6] mac80211: update ht flag if bss configuration changed
Date: Mon, 18 Nov 2013 19:02:44 +0200	[thread overview]
Message-ID: <1384794166-10906-4-git-send-email-egrumbach@gmail.com> (raw)
In-Reply-To: <1384794166-10906-1-git-send-email-egrumbach@gmail.com>

From: Avri Altman <avri.altman@intel.com>

The bug concerned failing to update the ht flag properly.
updating the ht flag when bss configuration changes should
be done independently of channel changes.

Signed-off-by: Avri Altman <avri.altman@intel.com>
Reviewed-by: Johannes Berg <johannes.berg@intel.com>
---
 net/mac80211/mlme.c |   18 ++++++++++--------
 1 file changed, 10 insertions(+), 8 deletions(-)

diff --git a/net/mac80211/mlme.c b/net/mac80211/mlme.c
index b3a3ce3..03aa33f 100644
--- a/net/mac80211/mlme.c
+++ b/net/mac80211/mlme.c
@@ -330,6 +330,16 @@ static int ieee80211_config_bw(struct ieee80211_sub_if_data *sdata,
 	if (WARN_ON_ONCE(!sta))
 		return -EINVAL;
 
+	/*
+	 * if bss configuration changed store the new one -
+	 * this may be applicable even if channel is identical
+	 */
+	ht_opmode = le16_to_cpu(ht_oper->operation_mode);
+	if (sdata->vif.bss_conf.ht_operation_mode != ht_opmode) {
+		*changed |= BSS_CHANGED_HT;
+		sdata->vif.bss_conf.ht_operation_mode = ht_opmode;
+	}
+
 	chan = sdata->vif.bss_conf.chandef.chan;
 	sband = local->hw.wiphy->bands[chan->band];
 
@@ -416,14 +426,6 @@ static int ieee80211_config_bw(struct ieee80211_sub_if_data *sdata,
 					 IEEE80211_RC_BW_CHANGED);
 	}
 
-	ht_opmode = le16_to_cpu(ht_oper->operation_mode);
-
-	/* if bss configuration changed store the new one */
-	if (sdata->vif.bss_conf.ht_operation_mode != ht_opmode) {
-		*changed |= BSS_CHANGED_HT;
-		sdata->vif.bss_conf.ht_operation_mode = ht_opmode;
-	}
-
 	return 0;
 }
 
-- 
1.7.9.5


  parent reply	other threads:[~2013-11-18 17:02 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-18 17:02 [PATCH 1/6] mac80211: Tx frame latency statistics Emmanuel Grumbach
2013-11-18 17:02 ` [PATCH 2/6] mac80211: fix connection polling Emmanuel Grumbach
2013-11-18 17:02 ` [PATCH 3/6] mac80211: remove sta_info_flush() from interface teardown Emmanuel Grumbach
2013-11-18 17:02 ` Emmanuel Grumbach [this message]
2013-11-18 17:02 ` [PATCH 5/6] cfg80211: Aggregate mgmt_tx parameters into a struct Emmanuel Grumbach
2013-11-18 17:02 ` [PATCH 6/6] cfg80211: Fix setting channel in mgmt_tx parameters Emmanuel Grumbach
2013-11-18 17:04   ` Emmanuel Grumbach
2013-11-18 17:06 ` [PATCH RESEND 1/5] mac80211: Tx frame latency statistics Emmanuel Grumbach
2013-11-18 17:06   ` [PATCH RESEND 2/5] mac80211: fix connection polling Emmanuel Grumbach
2013-11-19 13:04     ` Stanislaw Gruszka
2013-11-19 14:24       ` Johannes Berg
2013-11-18 17:06   ` [PATCH RESEND 3/5] mac80211: remove sta_info_flush() from interface teardown Emmanuel Grumbach
2013-11-18 17:06   ` [PATCH RESEND 4/5] mac80211: update ht flag if bss configuration changed Emmanuel Grumbach
2013-11-18 17:06   ` [PATCH RESEND 5/5] cfg80211: Aggregate mgmt_tx parameters and fix channel setting Emmanuel Grumbach
2013-11-19 14:26     ` Johannes Berg
2013-11-19 14:35     ` Johannes Berg
2013-11-19 15:19       ` Emmanuel Grumbach
2013-11-19 15:02   ` [PATCH RESEND 1/5] mac80211: Tx frame latency statistics Johannes Berg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1384794166-10906-4-git-send-email-egrumbach@gmail.com \
    --to=egrumbach@gmail.com \
    --cc=avri.altman@intel.com \
    --cc=johannes@sipsolutions.net \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).