From: Emmanuel Grumbach <egrumbach@gmail.com>
To: johannes@sipsolutions.net
Cc: linux-wireless@vger.kernel.org, Johannes Berg <johannes.berg@intel.com>
Subject: [PATCH RESEND 3/5] mac80211: remove sta_info_flush() from interface teardown
Date: Mon, 18 Nov 2013 19:06:47 +0200 [thread overview]
Message-ID: <1384794409-11211-3-git-send-email-egrumbach@gmail.com> (raw)
In-Reply-To: <1384794409-11211-1-git-send-email-egrumbach@gmail.com>
From: Johannes Berg <johannes.berg@intel.com>
All interface types now properly clean up their stations
using some form of sta_info_flush() themselves, so there's
no need to try it again at teardown. Remove the call to
get rid of the extra delay from the synchronize_net() and
rcu_barrier() calls.
Reported-by: Moshe Benji <moshe.benji@intel.com>
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
---
net/mac80211/iface.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/net/mac80211/iface.c b/net/mac80211/iface.c
index ff101ea..a3d106d 100644
--- a/net/mac80211/iface.c
+++ b/net/mac80211/iface.c
@@ -1036,7 +1036,6 @@ static void ieee80211_set_multicast_list(struct net_device *dev)
*/
static void ieee80211_teardown_sdata(struct ieee80211_sub_if_data *sdata)
{
- int flushed;
int i;
/* free extra data */
@@ -1050,9 +1049,6 @@ static void ieee80211_teardown_sdata(struct ieee80211_sub_if_data *sdata)
if (ieee80211_vif_is_mesh(&sdata->vif))
mesh_rmc_free(sdata);
-
- flushed = sta_info_flush(sdata);
- WARN_ON(flushed);
}
static void ieee80211_uninit(struct net_device *dev)
--
1.7.9.5
next prev parent reply other threads:[~2013-11-18 17:06 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-18 17:02 [PATCH 1/6] mac80211: Tx frame latency statistics Emmanuel Grumbach
2013-11-18 17:02 ` [PATCH 2/6] mac80211: fix connection polling Emmanuel Grumbach
2013-11-18 17:02 ` [PATCH 3/6] mac80211: remove sta_info_flush() from interface teardown Emmanuel Grumbach
2013-11-18 17:02 ` [PATCH 4/6] mac80211: update ht flag if bss configuration changed Emmanuel Grumbach
2013-11-18 17:02 ` [PATCH 5/6] cfg80211: Aggregate mgmt_tx parameters into a struct Emmanuel Grumbach
2013-11-18 17:02 ` [PATCH 6/6] cfg80211: Fix setting channel in mgmt_tx parameters Emmanuel Grumbach
2013-11-18 17:04 ` Emmanuel Grumbach
2013-11-18 17:06 ` [PATCH RESEND 1/5] mac80211: Tx frame latency statistics Emmanuel Grumbach
2013-11-18 17:06 ` [PATCH RESEND 2/5] mac80211: fix connection polling Emmanuel Grumbach
2013-11-19 13:04 ` Stanislaw Gruszka
2013-11-19 14:24 ` Johannes Berg
2013-11-18 17:06 ` Emmanuel Grumbach [this message]
2013-11-18 17:06 ` [PATCH RESEND 4/5] mac80211: update ht flag if bss configuration changed Emmanuel Grumbach
2013-11-18 17:06 ` [PATCH RESEND 5/5] cfg80211: Aggregate mgmt_tx parameters and fix channel setting Emmanuel Grumbach
2013-11-19 14:26 ` Johannes Berg
2013-11-19 14:35 ` Johannes Berg
2013-11-19 15:19 ` Emmanuel Grumbach
2013-11-19 15:02 ` [PATCH RESEND 1/5] mac80211: Tx frame latency statistics Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1384794409-11211-3-git-send-email-egrumbach@gmail.com \
--to=egrumbach@gmail.com \
--cc=johannes.berg@intel.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).